Skip to content

Comments

KER-422 hearing projects fixes#1112

Merged
mikkojamG merged 2 commits intomainfrom
fix/KER-422-hearing-projects
Feb 13, 2025
Merged

KER-422 hearing projects fixes#1112
mikkojamG merged 2 commits intomainfrom
fix/KER-422-hearing-projects

Conversation

@mikkojamG
Copy link
Contributor

@mikkojamG mikkojamG commented Feb 12, 2025 •
edited
Loading

Fixing hearing project fields, which are currently overall broken.

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1112-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

e2e tests result is success for https://kerrokantasi-pr1112-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1112-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

e2e tests result is success for https://kerrokantasi-pr1112-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1112-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

e2e tests result is failed for https://kerrokantasi-pr1112-ui.dev.hel.ninja 😿💢💥💥

@mikkojamG mikkojamG force-pushed the fix/KER-422-hearing-projects branch from 22165b4 to 3406dbf Compare February 12, 2025 10:12
@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1112-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

e2e tests result is success for https://kerrokantasi-pr1112-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG force-pushed the fix/KER-422-hearing-projects branch from f390697 to 1fbc612 Compare February 12, 2025 10:38
@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1112-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

e2e tests result is success for https://kerrokantasi-pr1112-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1112-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

e2e tests result is failed for https://kerrokantasi-pr1112-ui.dev.hel.ninja 😿💢💥💥

@mikkojamG mikkojamG force-pushed the fix/KER-422-hearing-projects branch 2 times, most recently from 4f0faff to 37200bd Compare February 12, 2025 12:16
@mikkojamG mikkojamG force-pushed the fix/KER-422-hearing-projects branch from 4e8c85b to d21f0ff Compare February 12, 2025 12:22
@mikkojamG mikkojamG changed the title [WIP] KER-422 hearing projects [WIP] KER-422 hearing projects fixes Feb 12, 2025
@mikkojamG mikkojamG changed the title [WIP] KER-422 hearing projects fixes KER-422 hearing projects fixes Feb 12, 2025
@mikkojamG mikkojamG marked this pull request as ready for review February 12, 2025 12:27
@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1112-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 12, 2025

e2e tests result is success for https://kerrokantasi-pr1112-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG requested a review from arpargo February 12, 2025 12:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 13, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
66.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 13, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1112-ui.dev.hel.ninja 🚀🚀🚀

arpargo
arpargo approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@arpargo arpargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terovirtanen
Copy link
Contributor

terovirtanen commented Feb 13, 2025

e2e tests result is success for https://kerrokantasi-pr1112-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG merged commit 4499024 into main Feb 13, 2025
23 checks passed
@mikkojamG mikkojamG deleted the fix/KER-422-hearing-projects branch February 13, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arpargo arpargo arpargo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikkojamG @terovirtanen @arpargo