Skip to content

fix: fixed fileupload not working as intended #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arpargo merged 2 commits into from
Mar 27, 2025
Merged

fix: fixed fileupload not working as intended #1135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67946fe
fix: fixed fileupload not working as intended
arpargo Mar 25, 2025
b202970
chore: fix linter errors
arpargo Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions src/components/admin/SectionForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ const fetchFiles = async (data, fileType, language) => {

const response = await fetch(item.url, {
method: 'GET',
mode: 'no-cors',
});

const blob = await response.blob();

const type = fileType === 'image' ? 'image/webp' : 'application/pdf';
Expand Down Expand Up @@ -111,7 +109,6 @@ const SectionForm = ({
async function fetchAttachments() {
if (section.files.length) {
const data = await fetchFiles(section.files, 'pdf', language);

setAttachments(data);
}
}
Expand Down Expand Up @@ -167,18 +164,18 @@ const SectionForm = ({
*/
const onAttachmentChange = (files) => {
const filesToDelete = attachments?.filter(
(item, oldIndex) =>
(item) =>
!files.some(
(newFile, newIndex) =>
item.file.name === newFile.name && item.file.size === newFile.size && oldIndex === newIndex,
(newFile) =>
item.file.name === newFile.name && item.file.size === newFile.size
),
);

const filesToAdd = files.filter(
(newFile, newIndex) =>
(newFile) =>
!attachments?.some(
(item, oldIndex) =>
newFile.name === item.file.name && newFile.size === item.file.size && newIndex === oldIndex,
(item) =>
newFile.name === item.file.name && newFile.size === item.file.size
),
);

Expand All @@ -191,7 +188,6 @@ const SectionForm = ({

filesToAdd.forEach(async (file) => {
const blob = await fileToDataUri(file);

onSectionAttachment(section.frontId, blob, { [language]: file.name });
});
}
Expand Down Expand Up @@ -391,7 +387,7 @@ const SectionForm = ({
accept={ACCEPTED_FILE_TYPES}
language={language}
onChange={onAttachmentChange}
defaultValue={attachments}
defaultValue={attachments?.map(item => item.file) || []}
maxSize={MAX_FILE_SIZE * 1024 * 1024}
multiple
/>
Expand Down
Loading