Skip to content

Comments

fix: hearing saveAndPreview fix for existing hearings#1138

Merged
arpargo merged 4 commits intomainfrom
KER-472-section-fix
Apr 7, 2025
Merged

fix: hearing saveAndPreview fix for existing hearings#1138
arpargo merged 4 commits intomainfrom
KER-472-section-fix

Conversation

@arpargo
Copy link
Contributor

@arpargo arpargo commented Apr 4, 2025

Editing hearing that was unpublished caused sections to have empty id's when sent to backend which in return caused new sections to be generated for hearing.

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1138-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

e2e tests result is failed for https://kerrokantasi-pr1138-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1138-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

e2e tests result is failed for https://kerrokantasi-pr1138-ui.dev.hel.ninja 😿💢💥💥

1 similar comment
@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

e2e tests result is failed for https://kerrokantasi-pr1138-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1138-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

e2e tests result is failed for https://kerrokantasi-pr1138-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1138-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

e2e tests result is failed for https://kerrokantasi-pr1138-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1138-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

e2e tests result is failed for https://kerrokantasi-pr1138-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1138-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 4, 2025

e2e tests result is failed for https://kerrokantasi-pr1138-ui.dev.hel.ninja 😿💢💥💥

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 7, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1138-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 7, 2025

e2e tests result is success for https://kerrokantasi-pr1138-ui.dev.hel.ninja 😆🎉🎉🎉

@arpargo arpargo merged commit b2b2e96 into main Apr 7, 2025
23 checks passed
@arpargo arpargo deleted the KER-472-section-fix branch April 7, 2025 06:52
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Merged
mikkojamG pushed a commit that referenced this pull request Apr 9, 2025
@arpargo @mikkojamG
fix: hearing saveAndPreview fix for existing hearings (#1138)
880d8f9 
* fix: hearing saveAndPreview fix for existing hearings

* chore: fix linter errors

* fix: fixed e2e test being giga flaky

* fix: fixed hearing page e2e test to use slug instead of ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikkojamG mikkojamG mikkojamG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arpargo @terovirtanen @mikkojamG