fix: hearingEditor middleware infinite recursion Refs: KER-590#1254
fix: hearingEditor middleware infinite recursion Refs: KER-590#1254
Conversation
mikkojamG
force-pushed
the
fix/KER-590-hearing-editor-infinite-recursion
branch
from
ac52709 to
c6fc4fb
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1254-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://kerrokantasi-pr1254-ui.dev.hel.ninja 😆🎉🎉🎉 |
mikkojamG
force-pushed
the
fix/KER-590-hearing-editor-infinite-recursion
branch
2 times, most recently
from
51baea5 to
8c26323
Compare
mikkojamG
force-pushed
the
fix/KER-590-hearing-editor-infinite-recursion
branch
from
8c26323 to
5ef6e2e
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a Sentry-reported infinite recursion in the hearing editor middleware by attempting to mark handled actions as “normalized”, and adds middleware unit tests to cover the new behavior.
Changes:
- Updates
normalizeReceivedHearingto use a sharedSetof action types and to add anisNormalizedflag to prevent reprocessing. - Adds a new middleware test suite covering normalization, editor syncing, and frontId behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/middleware/hearingEditor.js |
Changes the hearing normalization/sync middleware logic to avoid repeated processing. |
src/middleware/__tests__/hearingEditor.test.js |
Adds tests intended to validate the middleware behaviors and guard against recursion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1254-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://kerrokantasi-pr1254-ui.dev.hel.ninja 😆🎉🎉🎉 |
mikkojamG
force-pushed
the
fix/KER-590-hearing-editor-infinite-recursion
branch
from
5ef6e2e to
e8d9677
Compare
|
KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1254-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://kerrokantasi-pr1254-ui.dev.hel.ninja 😆🎉🎉🎉 |
mikkojamG
force-pushed
the
fix/KER-590-hearing-editor-infinite-recursion
branch
from
e8d9677 to
718fa91
Compare
|
KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1254-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://kerrokantasi-pr1254-ui.dev.hel.ninja 😆🎉🎉🎉 |
mikkojamG
force-pushed
the
fix/KER-590-hearing-editor-infinite-recursion
branch
from
718fa91 to
2684dfc
Compare
mikkojamG
force-pushed
the
fix/KER-590-hearing-editor-infinite-recursion
branch
from
2684dfc to
55ce4c3
Compare
|
|
KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1254-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://kerrokantasi-pr1254-ui.dev.hel.ninja 😆🎉🎉🎉 |
2 participants
KER-590
KERROKANTASI-UI-2E