Skip to content

Comments

Update indoor facility accessibility rules for visually impaired setting#366

Merged
mhieta merged 2 commits intomainfrom
PL-45/accessibility-rules-updates
Jan 21, 2026
Merged

Update indoor facility accessibility rules for visually impaired setting#366
mhieta merged 2 commits intomainfrom
PL-45/accessibility-rules-updates

Conversation

@mhieta
Copy link
Contributor

@mhieta mhieta commented Jan 21, 2026

Description

Update indoor facility accessibility rules for visually impaired setting.

Context

PL-45

How Has This Been Tested?

Through newly added test suite for the accessibility shortcoming calculator.

Screenshots

kalliion kirjasto oodi

@mhieta mhieta requested a review from a team as a code owner January 21, 2026 06:31
@azure-pipelines
Copy link

PALVELUKARTTA-API branch is deployed to platta: https://palvelukartta-api-pr366.dev.hel.ninja 🚀🚀🚀

Add comprehensive test coverage for
AccessibilityShortcomingCalculator including:
- Singleton pattern and rule evaluation (EQ, NEQ, AND, OR)
- Message recording and short-circuit logic
- All 6 profiles and 11 path types
- Edge cases and error handling

Tests organized into 9 classes with proper fixtures.

Refs: PL-45
Update indoor facility accessibility rules
for visually impaired setting.

Refs: PL-45
@mhieta mhieta force-pushed the PL-45/accessibility-rules-updates branch from 7449694 to 5483e6b Compare January 21, 2026 07:09
Copy link
Contributor

@danipran danipran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README is probably a bit redundant, I'd delete it. Otherwise, LGTM! 👍

@mhieta
Copy link
Contributor Author

mhieta commented Jan 21, 2026

The README is probably a bit redundant, I'd delete it. Otherwise, LGTM! 👍

README deleted now.

@sonarqubecloud
Copy link

@mhieta mhieta merged commit 2b66175 into main Jan 21, 2026
6 checks passed
@mhieta mhieta deleted the PL-45/accessibility-rules-updates branch January 21, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants