Closed
Conversation
Also add tests. Refs: PL-214
mhieta
force-pushed
the
seer/fix/api-distinct-id
branch
from
f5c3214 to
4613477
Compare
|
|
PALVELUKARTTA-API branch is deployed to platta: https://palvelukartta-api-pr371.dev.hel.ninja 🚀🚀🚀 |
voneiden
requested changes
Jan 26, 2026
Contributor
voneiden
left a comment
voneiden
left a comment
There was a problem hiding this comment.
Not compatible with filters that change order_by to something else than id. For example distance filter sets order_by("distance")
This results in a ProgrammingError when filters are combined
https://city-of-helsinki.sentry.io/issues/91057892/
(No error in test env https://palvelukartta.api.test.hel.ninja/v2/unit/?lat=60&lon=25&distance=100000000&service_node=6 )
Contributor
Author
|
Closing this PR as a duplicate to #373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure distinct results in API queries.
Context
PL-214