fix: prevent SQL injection in search queries#386
Merged
Conversation
Replace f-string SQL construction with parameterized queries using psycopg.sql module. Sanitize user-controlled values like language_short and config_language that were directly interpolated into SQL strings. - Use sql.SQL() with sql.Identifier() for column names - Use sql.Literal() for configuration values - Pass search_query_str and limits as query parameters - Apply fix to both conditional branches in main search query - Apply similar parameterization to address sorting query This ensures all user input is properly sanitized before being executed as SQL queries. Refs: PL-210
|
PALVELUKARTTA-API branch is deployed to platta: https://palvelukartta-api-pr386.dev.hel.ninja 🚀🚀🚀 |
The test was failing with a 509 error because it was making actual HTTP requests to the Nominatim geocoding service. Added @patch decorator to mock the geocode_address function, preventing external API calls and ensuring reliable test execution. The mock returns controlled coordinates to test both inside and outside the test area boundaries. Refs: PL-210
|
|
PALVELUKARTTA-API branch is deployed to platta: https://palvelukartta-api-pr386.dev.hel.ninja 🚀🚀🚀 |
nicobav
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace f-string SQL construction with parameterized queries using psycopg.sql module. Sanitize user-controlled values like language_short and config_language that were directly interpolated into SQL strings.
This ensures all user input is properly sanitized before being executed as SQL queries.
Context
PL-210