Skip to content

Comments

Replace black, flake8 and isort with ruff#3773

Merged
voneiden merged 39 commits intomainfrom
ruff
Oct 2, 2025
Merged

Replace black, flake8 and isort with ruff#3773
voneiden merged 39 commits intomainfrom
ruff

Conversation

@voneiden
Copy link
Contributor

@voneiden voneiden commented Sep 24, 2025

This PR implements ruff in place of black, flake8 and isort. The configuration is the default configuration as recommended by https://helsinkisolutionoffice.atlassian.net/wiki/spaces/OS/pages/8466563320/3.+Coding+standards

Checks are done with pre-commit like before but one significant difference is that pre-commit is run now for every PR in GH workflow rather than as Azure pipeline.

@terovirtanen
Copy link
Contributor

YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3773.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://nuortenkesaseteli-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-ui-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3773.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3773.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3773.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3773.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://nuortenkesaseteli-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-ui-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3773.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3773.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr3773.dev.hel.ninja 🚀🚀🚀

husky is run via pre-commit in this project. Having a prepare script
that runs husky would cause git hook path to be overriden and prevent
pre-commit working until hookPath was unset.

Additionally commitlint packages are not needed for husky anymore
as pre-commit runs commitlint.

refs: HL-1625
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'yjdh'

Failed conditions
9 Security Hotspots

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3773.api.dev.hel.ninja 🚀🚀🚀

@sonarqubecloud
Copy link

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3773.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-ui-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://nuortenkesaseteli-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3773.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3773.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr3773.dev.hel.ninja 😆🎉🎉🎉

@voneiden voneiden requested review from a team and Riippi September 30, 2025 12:30
@voneiden voneiden merged commit 4c860e3 into main Oct 2, 2025
135 checks passed
@voneiden voneiden deleted the ruff branch October 2, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants