Skip to content

Comments

test(benefit): hardcode employee name in test to remove flakiness#3787

Merged
voneiden merged 1 commit intomainfrom
fix-flaky-employee-name
Oct 20, 2025
Merged

test(benefit): hardcode employee name in test to remove flakiness#3787
voneiden merged 1 commit intomainfrom
fix-flaky-employee-name

Conversation

@voneiden
Copy link
Contributor

test_Generate_composed_template_html could be flaky if faker generated employee names that matched partially applicant names. For example Martti matching Marttinen

refs: HL-1625

@voneiden voneiden requested a review from a team as a code owner October 20, 2025 08:06
test_Generate_composed_template_html could be flaky if faker generated
employee names that matched partially applicant names. For example
Martti matching Marttinen

refs: HL-1625
@voneiden voneiden force-pushed the fix-flaky-employee-name branch from 97ae045 to d468068 Compare October 20, 2025 10:53
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@terovirtanen
Copy link
Contributor

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3787.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3787.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3787.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3787.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3787.dev.hel.ninja 😆🎉🎉🎉

@voneiden voneiden merged commit c07567d into main Oct 20, 2025
63 checks passed
@voneiden voneiden deleted the fix-flaky-employee-name branch October 20, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants