Skip to content

Comments

Fix flaky test and clone bug#3788

Merged
voneiden merged 4 commits intomainfrom
fix-flaky-and-clone-bug
Oct 22, 2025
Merged

Fix flaky test and clone bug#3788
voneiden merged 4 commits intomainfrom
fix-flaky-and-clone-bug

Conversation

@voneiden
Copy link
Contributor

No description provided.

This test could generate false positives eg calculated benefit amount
matching company business id. Added a little bit of xml syntax to the
test material to make false partial matches impossible.

refs: HL-1625
This is done just in case, as the test has an assumption about "bit
later" being 2024-10-23. Time frozen initially to 2024-10-22.

refs: HL-1625
Previously the calculation would not take into account pay subsidies and
training compensations as they were cloned after the calculation.
Judging from the comment "Clone calculation with compensations and pay
subsidies" AND a failing test when application includes pay subsidies or
compensations indicates that the old behaviour may be unintentional.

refs: HL-1625
Old style would start producing invalid phone numbers after sequence
999. New one should be good for 998999 sequences.

refs: HL-1625
@voneiden voneiden requested a review from a team as a code owner October 21, 2025 10:49
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@terovirtanen
Copy link
Contributor

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3788.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3788.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3788.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3788.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3788.dev.hel.ninja 😆🎉🎉🎉

Copy link
Contributor

@nicobav nicobav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voneiden voneiden merged commit 9537a00 into main Oct 22, 2025
63 checks passed
@voneiden voneiden deleted the fix-flaky-and-clone-bug branch October 22, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants