Add timeouts to auth and clarify updating is_staff field#3822
Add timeouts to auth and clarify updating is_staff field#3822nikomakela merged 2 commits intomainfrom
Conversation
YJDH-622. The calls to the Microsoft Graph API using requests were missing a timeout. If the Graph API would have hanged or had been slow, it could tie up application threads indefinitely.
YJDH-622. Make it more clear that the auth logic forcefully overwrites the is_staff flag on every login based on AD groups.
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3822.api.dev.hel.ninja 🚀🚀🚀 |
|
|
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3822.dev.hel.ninja 🚀🚀🚀 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3822.api.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3822.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3822.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3822.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://nuortenkesaseteli-pr3822.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-pr3822.dev.hel.ninja 😆🎉🎉🎉 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3822.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3822.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3822.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3822.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
left a comment
karisal-anders
left a comment
There was a problem hiding this comment.
Approval from Kesäseteli side
4 participants
YJDH-622.