Skip to content

Comments

feat(kesaseteli,admin): admin employer applications and vouchers#3840

Merged
nikomakela merged 4 commits intomainfrom
YJDH-791-employer-application-admin
Jan 21, 2026
Merged

feat(kesaseteli,admin): admin employer applications and vouchers#3840
nikomakela merged 4 commits intomainfrom
YJDH-791-employer-application-admin

Conversation

@nikomakela
Copy link
Contributor

@nikomakela nikomakela commented Jan 15, 2026

YJDH-791 YJDH-792.

Register Organisation, EmployerApplication and EmployerSummerVoucher with multiple filters and search fields to Django's admin site.

A EmployerApplication can only be updated from it's employment details and employee info parts, it cannot be deleted and a new one cannot be created via admin site.

Applications:

image image

Summer vouchers:

image image

@nikomakela nikomakela requested a review from a team as a code owner January 15, 2026 07:46
@nikomakela nikomakela marked this pull request as draft January 15, 2026 07:46
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from b5c10c0 to 1860f98 Compare January 15, 2026 07:47
]

def has_add_permission(self, request):
"""Disable adding new applications."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g.

Suggested change
"""Disable adding new applications."""
"""Disable adding new employer summer vouchers."""

return False

def has_delete_permission(self, request, obj=None):
"""Disable deleting applications."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g.

Suggested change
"""Disable deleting applications."""
"""Disable deleting employer summer vouchers."""

Copy link
Collaborator

@karisal-anders karisal-anders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the verbose names for EmployerApplication and EmployerSummerVoucher models -> Getting less ambiguous names for them in Django admin would be good. Otherwise looks quite ok already, let's have a look when this is not a draft & tests have passed (Probably tests are only run for "merge to main" PRs?)

@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch 2 times, most recently from eb1658e to a1b0d9c Compare January 15, 2026 12:41
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 1860f98 to 388697b Compare January 15, 2026 12:41
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from a1b0d9c to c87c52e Compare January 16, 2026 07:52
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 388697b to 9efe24b Compare January 16, 2026 07:52
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from c87c52e to fd309ce Compare January 16, 2026 14:55
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 9efe24b to 1261315 Compare January 16, 2026 14:55
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from fd309ce to f2e0ce5 Compare January 16, 2026 15:10
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 1261315 to df557a2 Compare January 16, 2026 15:10
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from f2e0ce5 to f166d71 Compare January 16, 2026 15:39
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from df557a2 to fde5778 Compare January 16, 2026 15:39
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from f166d71 to 1806d31 Compare January 19, 2026 10:28
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from fde5778 to a632676 Compare January 19, 2026 10:28
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from 1806d31 to 37a0b53 Compare January 19, 2026 10:41
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from a632676 to 19140ca Compare January 19, 2026 10:41
@nikomakela nikomakela marked this pull request as ready for review January 19, 2026 11:53
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from 3e828d6 to a3fd320 Compare January 19, 2026 13:22
@nikomakela nikomakela requested a review from a team as a code owner January 19, 2026 13:22
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 19140ca to a5256b9 Compare January 19, 2026 13:22
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from a3fd320 to d65a340 Compare January 19, 2026 13:46
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from a5256b9 to ddb4e55 Compare January 19, 2026 13:46
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from d65a340 to 46aa72b Compare January 19, 2026 14:42
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 3c5e8c4 to b83a336 Compare January 19, 2026 15:01
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from d2cd64b to 4af556a Compare January 20, 2026 11:22
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from b83a336 to 6c93fcf Compare January 20, 2026 11:22
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from 4af556a to fedb3ee Compare January 20, 2026 14:43
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 6c93fcf to e40e7ef Compare January 20, 2026 14:43
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from fedb3ee to fa60765 Compare January 20, 2026 16:07
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from e40e7ef to 6424f60 Compare January 20, 2026 16:08
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from fa60765 to 8285953 Compare January 20, 2026 16:10
@nikomakela nikomakela requested a review from a team as a code owner January 20, 2026 16:10
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 6424f60 to 04a0d76 Compare January 20, 2026 16:10
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from 8285953 to 4c67ca7 Compare January 21, 2026 07:56
@nikomakela nikomakela force-pushed the YJDH-791-youth-application-admin branch from 04a0d76 to e9f6790 Compare January 21, 2026 07:56
Base automatically changed from YJDH-791-youth-application-admin to main January 21, 2026 09:16
YJDH-791.

Django admin site can be used to list and view organisations and their
data. No additions, changes or deletions are allowed via admin site.

NOTE: Registering companies to admin site makes it possible to use
company as a search field in other admin views.
YJDH-791 YJDH-792.

Register `EmployerApplication` and `EmployerSummerVoucher` with multiple
filters and search fields to Django's admin site.

A `EmployerApplication` can only be updated from it's employment details
and employee info parts, it cannot be deleted and a new one cannot be
created via admin site.
YJDH-791.

Change verbose names for employer application and employer summer
voucher, because without context it was unclear what voucher or
application was meant. This was especially frustrating when using admin
site, where the models are listed in left side panel.
@nikomakela nikomakela force-pushed the YJDH-791-employer-application-admin branch from 4c67ca7 to e456f1d Compare January 21, 2026 09:18
@nikomakela nikomakela merged commit 0504a18 into main Jan 21, 2026
5 of 20 checks passed
@nikomakela nikomakela deleted the YJDH-791-employer-application-admin branch January 21, 2026 09:18
@azure-pipelines
Copy link

YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3840.api.dev.hel.ninja 🚀🚀🚀

@sonarqubecloud
Copy link

@azure-pipelines
Copy link

YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3840.dev.hel.ninja 🚀🚀🚀

@azure-pipelines
Copy link

EMPLOYER branch is deployed to platta: https://kesaseteli-pr3840.dev.hel.ninja 🚀🚀🚀

@azure-pipelines
Copy link

HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3840.dev.hel.ninja 🚀🚀🚀

@azure-pipelines
Copy link

TestCafe result is success for https://nuortenkesaseteli-pr3840.dev.hel.ninja 😆🎉🎉🎉

@azure-pipelines
Copy link

TestCafe result is success for https://kesaseteli-handler-ui-pr3840.dev.hel.ninja 😆🎉🎉🎉

@azure-pipelines
Copy link

TestCafe result is success for https://kesaseteli-pr3840.dev.hel.ninja 😆🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants