feat(kesaseteli,admin): resend youth summer vouchers#3843
Merged
nikomakela merged 2 commits intomainfrom Jan 21, 2026
Merged
Conversation
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
from
7df1c13 to
9e481f8
Compare
|
|
||
| youth_application_link.short_description = _("youth application") | ||
|
|
||
| @admin.action(description=_("Resend summer voucher to selected applicants")) |
Collaborator
There was a problem hiding this comment.
send_youth_summer_voucher_email has default values for send_to_youth=True and send_to_handler=True, so it is sent to applicant and handler both now. How about making this clear to the user by e.g. renaming the description:
Suggested change
| @admin.action(description=_("Resend summer voucher to selected applicants")) | |
| @admin.action(description=_("Resend summer voucher to selected applicants and to the handler")) |
karisal-anders
approved these changes
Jan 19, 2026
Collaborator
karisal-anders
left a comment
karisal-anders
left a comment
There was a problem hiding this comment.
Left a comment about making it clear to the user that the resend functionality sends the email also to the handler, not just to the applicants (That's what it is doing at the moment). Otherwise ok.
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
from
3e828d6 to
a3fd320
Compare
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
from
9e481f8 to
4d2e211
Compare
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
from
a3fd320 to
d65a340
Compare
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
2 times, most recently
from
d961147 to
2c68106
Compare
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
from
d65a340 to
46aa72b
Compare
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
2 times, most recently
from
2510b82 to
fb48950
Compare
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
from
46aa72b to
d2cd64b
Compare
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
2 times, most recently
from
838ec4b to
676ee4b
Compare
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
2 times, most recently
from
4af556a to
fedb3ee
Compare
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
2 times, most recently
from
07a0c50 to
c1542dc
Compare
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
from
fedb3ee to
fa60765
Compare
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
from
c1542dc to
c820345
Compare
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
from
fa60765 to
8285953
Compare
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
from
c820345 to
347f9b1
Compare
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
from
8285953 to
4c67ca7
Compare
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
from
347f9b1 to
90c5cc5
Compare
nikomakela
force-pushed
the
YJDH-791-employer-application-admin
branch
from
4c67ca7 to
e456f1d
Compare
YJDH-694. Register an admin action that can be used to resend the already created (and sent) youth summer vouchers.
YJDH-799. YJDH-694.
nikomakela
force-pushed
the
YJDH-799-resend-voucher-email
branch
from
90c5cc5 to
2f5567c
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3843.api.dev.hel.ninja 🚀🚀🚀 |
|
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3843.dev.hel.ninja 🚀🚀🚀 |
TestCafe handler result is failed for https://kesaseteli-handler-ui-pr3843.dev.hel.ninja 😿💢💥💥 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3843.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3843.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://nuortenkesaseteli-pr3843.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-pr3843.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3843.dev.hel.ninja 😆🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YJDH-694.
Register an admin action that can be used to resend the already created (and sent) youth summer vouchers.