feat(benefit): applicant ui to reflect 2026 changes by ext-hjasplund · Pull Request #3845 · City-of-Helsinki/yjdh

ext-hjasplund · 2026-01-21T04:06:29Z

Description

Changed UI fields according to new rules.
Changed localization.
Changed validation logic in the backend.
Fixed browser and backend tests.

Related Issue(s)

HL-1706

Motivation and Context

Rules for benefit application changed in the beginning of 2026.

How Has This Been Tested?

Tests existed beforehand

Changed UI fields according to new rules. Changed validation logic in the backend. Fixed browser and backend tests. Refs: HL-1706

azure-pipelines · 2026-01-21T04:23:20Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-21T04:28:19Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-21T04:29:24Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-21T04:34:48Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-01-21T04:35:10Z

TestCafe result is success for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-01-21T06:19:18Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-21T06:23:10Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-21T06:25:14Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-21T06:29:59Z

TestCafe result is success for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-01-21T06:30:35Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

voneiden

BE puolen validointi kaipaisi mielestäni vielä päivityksiä:

API sallii tällä hetkellä, että hakemus lähetetään ilman apprenticeship_program kenttää tai null arvolla. FE:n puolella kenttä on kuitenkin laitettu pakolliseksi. Olettaisin, että tulisi olla BE:ssä myös nyt pakollinen?
pay_subsidy_granted on kovakoodattu frontissa lähtemään arvolla NOT_GRANTED, mutta BE:ssä arvoa ei ole rajoitettu.
https://github.com/City-of-Helsinki/yjdh/pull/3845/files#diff-e2eff806ffa41db0f4ff4a1b85b0b0e1d6c6f8750640f09f4a769fd9adb8b912L997-L1009 Tällä ei varmaan pitäisi olla enää mitään virkaa (olettaen, että sallitaan vain NOT_GRANTED arvot serializerin kautta)

timwessman

Looks good on FE side!

azure-pipelines · 2026-01-22T09:48:54Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-22T09:52:58Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-22T09:54:32Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-22T09:56:51Z

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

azure-pipelines · 2026-01-22T09:59:35Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-01-22T12:03:52Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-22T12:06:38Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-22T12:08:30Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-22T12:14:12Z

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

azure-pipelines · 2026-01-22T12:14:17Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-01-26T04:49:39Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-26T04:54:19Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-26T04:58:08Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-26T05:00:27Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-02-03T06:00:02Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-03T06:00:27Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-03T06:05:46Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

Changed apprenticeship validation. Fixed tests. Refs: HL-1706

azure-pipelines · 2026-02-04T06:12:42Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-04T06:19:29Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-04T06:20:55Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-04T06:24:49Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-02-04T06:27:51Z

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

Changed apprenticeship validation. Fixed tests. Refs: HL-1706

azure-pipelines · 2026-02-09T06:27:46Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-09T06:31:49Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-09T06:33:09Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-09T06:37:20Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-02-09T06:40:26Z

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

Changed apprenticeship validation. Fixed tests. Refs: HL-1706

azure-pipelines · 2026-02-11T06:51:36Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-11T06:54:07Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-11T07:00:32Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-11T07:01:00Z

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

azure-pipelines · 2026-02-11T07:06:12Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

Fixed tests. Refs: HL-1706

Changed validation. Refs: HL-1706

azure-pipelines · 2026-02-12T05:33:50Z

YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3845.api.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-12T05:34:56Z

APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-12T05:38:50Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-02-12T05:40:06Z

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

azure-pipelines · 2026-02-12T05:45:30Z

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

azure-pipelines · 2026-02-16T08:52:52Z

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

feat(benefit): applicant ui to reflect 2026 changes

d50a5ed

Changed UI fields according to new rules. Changed validation logic in the backend. Fixed browser and backend tests. Refs: HL-1706

ext-hjasplund marked this pull request as ready for review January 21, 2026 06:02

ext-hjasplund requested review from a team as code owners January 21, 2026 06:02

voneiden requested changes Jan 21, 2026

View reviewed changes

timwessman approved these changes Jan 22, 2026

View reviewed changes

feat(benefit): applicant ui to reflect 2026 changes

3daeb7d

Changed apprenticeship validation. Fixed tests. Refs: HL-1706

feat(benefit): applicant ui to reflect 2026 changes

ae33900

Changed apprenticeship validation. Fixed tests. Refs: HL-1706

feat(benefit): applicant ui to reflect 2026 changes

fdd4a5f

Changed apprenticeship validation. Fixed tests. Refs: HL-1706

ext-hjasplund added 2 commits February 12, 2026 07:15

feat(benefit): applicant ui to reflect 2026 changes

4f33a86

Fixed tests. Refs: HL-1706

feat(benefit): applicant ui to reflect 2026 changes

6cf5947

Changed validation. Refs: HL-1706

ext-hjasplund closed this Feb 17, 2026

Comments

Conversation

ext-hjasplund commented Jan 21, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Motivation and Context

How Has This Been Tested?

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

Uh oh!

azure-pipelines bot commented Jan 21, 2026

TestCafe result is success for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😆🎉🎉🎉

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

TestCafe result is success for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😆🎉🎉🎉

Uh oh!

azure-pipelines bot commented Jan 21, 2026

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

Uh oh!

voneiden left a comment

Choose a reason for hiding this comment

Uh oh!

timwessman left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Jan 22, 2026

Uh oh!

azure-pipelines bot commented Jan 22, 2026

Uh oh!

azure-pipelines bot commented Jan 22, 2026

Uh oh!

azure-pipelines bot commented Jan 22, 2026

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

Uh oh!

azure-pipelines bot commented Jan 22, 2026

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

Uh oh!

azure-pipelines bot commented Jan 22, 2026

Uh oh!

azure-pipelines bot commented Jan 22, 2026

Uh oh!

azure-pipelines bot commented Jan 22, 2026

Uh oh!

azure-pipelines bot commented Jan 22, 2026

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3845.dev.hel.ninja 😿💢💥💥

Uh oh!

azure-pipelines bot commented Jan 22, 2026

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

Uh oh!

azure-pipelines bot commented Jan 26, 2026

Uh oh!

azure-pipelines bot commented Jan 26, 2026

Uh oh!

azure-pipelines bot commented Jan 26, 2026

Uh oh!

azure-pipelines bot commented Jan 26, 2026

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

Uh oh!

azure-pipelines bot commented Feb 3, 2026

Uh oh!

azure-pipelines bot commented Feb 3, 2026

Uh oh!

azure-pipelines bot commented Feb 3, 2026

TestCafe result is success for https://helsinkilisa-ui-pr3845.dev.hel.ninja 😆🎉🎉🎉

Uh oh!

azure-pipelines bot commented Feb 4, 2026

ext-hjasplund commented Jan 21, 2026 •

edited by atlassian bot

Loading