feat(ks): remove target_group field from employer summer voucher#3860
feat(ks): remove target_group field from employer summer voucher#3860nikomakela merged 1 commit intomainfrom
Conversation
nikomakela
force-pushed
the
YJDH-738-del-empl-trgt-grp
branch
3 times, most recently
from
499ea54 to
383d986
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3860.api.dev.hel.ninja 🚀🚀🚀 |
|
|
❌ The last analysis has failed. |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3860.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3860.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://nuortenkesaseteli-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3860.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
YJDH-738-del-empl-trgt-grp
branch
from
383d986 to
2cda2be
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3860.api.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3860.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://nuortenkesaseteli-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3860.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3860.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
YJDH-738-del-empl-trgt-grp
branch
2 times, most recently
from
9771215 to
b37112b
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3860.api.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3860.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3860.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3860.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://nuortenkesaseteli-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
left a comment
karisal-anders
left a comment
There was a problem hiding this comment.
Please consider adding a docstring/comment to EmployerSummerVoucher.target_group property for clarity saying that it is a backward compatibility property or something like that. Not a blocker, so you can add it or not.
YJDH-738. Remove the `target_group` database field from `EmployerSummerVoucher` and replace it with a custom property, that reads the value from the linked `YouthSummerVoucher` instance. The included migration processses moves the values from `EmployerSummerVoucher` to the linked `YouthSummerVoucher` instances and then alters the structure so that the target group is stored only in `YouthSummerVoucher`. Trying to keep some backward compatibility and methods for easy to use by adding a custom property for target group reading from `EmployerSummerVoucher`.
nikomakela
force-pushed
the
YJDH-738-del-empl-trgt-grp
branch
from
b37112b to
17d1e7a
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3860.api.dev.hel.ninja 🚀🚀🚀 |
|
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3860.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3860.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://nuortenkesaseteli-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3860.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3860.dev.hel.ninja 😆🎉🎉🎉 |
2 participants
YJDH-738.
Remove the
target_groupdatabase field fromEmployerSummerVoucherand replace it with a custom property, that reads the value from the linkedYouthSummerVoucherinstance.The included migration processses moves the values from
EmployerSummerVoucherto the linkedYouthSummerVoucherinstances and then alters the structure so that the target group is stored only inYouthSummerVoucher.Trying to keep some backward compatibility and methods for easy to use by adding a custom property for target group reading from
EmployerSummerVoucher.