fix(benefit): application disappears from "Maksuerät" tab#3861
fix(benefit): application disappears from "Maksuerät" tab#3861ext-hjasplund merged 1 commit intomainfrom
Conversation
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3861.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3861.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3861.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3861.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
There was a problem hiding this comment.
Actually this fix does not seem to change anything, because the should_filter_archived-variable is always True in the first if and always False in the second else. Or?
Also better add explicit tests for the fix to verify that the fix does what it is supposed to do.
|
The real issue seems to be in this function that filters out appliactions which have due_date in past.
|
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3861.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3861.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3861.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3861.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
ext-hjasplund
force-pushed
the
hl-1719-application-disappears
branch
from
d510f80 to
6136e50
Compare
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3861.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3861.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
ext-hjasplund
force-pushed
the
hl-1719-application-disappears
branch
from
2d5e2ea to
2ad820b
Compare
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3861.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3861.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
ext-hjasplund
force-pushed
the
hl-1719-application-disappears
branch
from
2ad820b to
be0d82a
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 🚀🚀🚀 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3861.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3861.dev.hel.ninja 🚀🚀🚀 |
Fix the issue where the applications disappear from the "Maksuerät" tab. Created a test. Refs: HL-1719
TestCafe result is success for https://helsinkilisa-ui-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
ext-hjasplund
force-pushed
the
hl-1719-application-disappears
branch
from
be0d82a to
c3986dd
Compare
|
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3861.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3861.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3861.dev.hel.ninja 😆🎉🎉🎉 |
4 participants
Description
Fixed query to allow for applications to remain on "Maksuerät" tab.
Related Issue(s)
HL-1719
Motivation and Context
Applications disappeared from "Maksuerät" tab after the first installment.