fix(ks): employer application should allow empty target group#3863
fix(ks): employer application should allow empty target group#3863nikomakela merged 1 commit intomainfrom
Conversation
YJDH-738. A critical fix to API data input serializer of employer application handling. When employer's UI creates a new draft, it always sends an empty target group. This empty string needs to be allowed also in serializer which is called by EmployerApplicationSerializer.
|
The UI should not try to send something that it does not have yet. Sending an empty form to create a draft should be replaced with something that sends only the given data. Or the creation of draft could even be totally omitted, but it's it's currently needed by the summary view. If the summary view would data from browser instead of draft data from database, the creation of draft could be omitted. |
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3863.api.dev.hel.ninja 🚀🚀🚀 |
|
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3863.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3863.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3863.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-pr3863.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3863.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://nuortenkesaseteli-pr3863.dev.hel.ninja 😆🎉🎉🎉 |
2 participants
YJDH-738.
A critical fix to API data input serializer of employer application handling. When employer's UI creates a new draft, it always sends an empty target group. This empty string needs to be allowed also in serializer which is called by EmployerApplicationSerializer.
Here clicking the "Load information..." -button, triggers an application creation with an empty string set as a target_group.
When a draft is created, the target group can be chosen and then when it's selected, it's also post to serializer as selected: