YJDH-806 | Backend: Add 15, 18 y.o. Helsinkian target groups, not defaults#3871
YJDH-806 | Backend: Add 15, 18 y.o. Helsinkian target groups, not defaults#3871karisal-anders merged 1 commit intomainfrom
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
backend/kesaseteli/applications/management/commands/create_summervoucher_configuration.py
Outdated
Show resolved
Hide resolved
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3871.api.dev.hel.ninja 🚀🚀🚀 |
karisal-anders
force-pushed
the
YJDH-806-add-15-18-target-groups
branch
from
72d7d27 to
39f41ce
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3871.api.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3871.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3871.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3871.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://nuortenkesaseteli-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
| @pytest.fixture(autouse=True) | ||
| def seed_default_configuration_for_tests(db): | ||
| target_groups = [identifier for identifier, _ in get_target_group_choices()] | ||
| default_target_groups = ["primary_target_group", "secondary_target_group"] |
There was a problem hiding this comment.
This could be read from settings.
There was a problem hiding this comment.
As we are currently not allowing the configuring of SUMMER_VOUCHER_DEFAULT_TARGET_GROUPS setting from environment this is ok, but if we'd be allowing configuring the setting from environment variables, then it'd IMHO be better not to read the value from settings but to use some prechosen values for the tests specifically—in order to make the tests more robust and not break if someone locally changes their .env.kesaseteli SUMMER_VOUCHER_DEFAULT_TARGET_GROUPS value.
karisal-anders
force-pushed
the
YJDH-806-add-15-18-target-groups
branch
from
39f41ce to
3b93a95
Compare
|
Force pushed changes. |
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3871.api.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3871.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3871.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3871.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://nuortenkesaseteli-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
also: - make "primary_target_group,secondary_target_group" the default target group selection when using create_summervoucher_configuration command - add support for "all" target groups to create_summervoucher_configuration - fix tests by not setting hki_15 and hki_18 target groups in tests - fix CSRF when accessing e.g. Django admin in local development refs YJDH-806
karisal-anders
force-pushed
the
YJDH-806-add-15-18-target-groups
branch
from
3b93a95 to
e45ef81
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3871.api.dev.hel.ninja 🚀🚀🚀 |
|
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3871.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3871.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3871.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://nuortenkesaseteli-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-pr3871.dev.hel.ninja 😆🎉🎉🎉 |
done: - "python manage.py makemigrations" refs YJDH-806
done: - "python manage.py makemigrations" refs YJDH-806
2 participants
Description ✨
Backend: Add 15, 18 y.o. Helsinkian target groups, not defaults
also:
Issues 🐛
YJDH-806
Testing ⚗️
Screenshots 📸
Additional notes 🗒️