feat(benefit): ui to reflect 2026 changes#3889
Conversation
Changed UI fields according to new rules. Fixed browser tests. Refs: HL-1706
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe applicant result is failed for https://helsinkilisa-ui-pr3889.dev.hel.ninja 😿💢💥💥 |
Fixed apprenticeship validation. Refs: HL-1706
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
Fixed the test for apprenticeship. Fixed tests to not contain granted pay subsidy. Refs: HL-1706
ext-hjasplund
force-pushed
the
hl-1706-ui-changes
branch
from
3a1ebc2 to
a72b855
Compare
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
|
|
||
| await step2.fillEmployeeInfo('Truu', 'Koos', '121148-8060'); | ||
| await step2.fillPaidSubsidyGrant(false); | ||
| // await step2.fillPaidSubsidyGrant(false); |
There was a problem hiding this comment.
There seems to be a lot of commented out code in the UI side. It should be deleted. If not deleted, it should be commented and documented why we need to keep it.
There was a problem hiding this comment.
Removed the commented out code.
Removed commented out code from browser tests. Refs: HL-1706
|
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3889.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3889.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3889.dev.hel.ninja 😆🎉🎉🎉 |
mrTuomoK
left a comment
mrTuomoK
left a comment
There was a problem hiding this comment.
For my eye and the front-end POV the PR looks good, just one comment to think of.
...nefit/applicant/src/components/applications/forms/application/step2/ApplicationFormStep2.tsx
Show resolved
Hide resolved
mrTuomoK
left a comment
mrTuomoK
left a comment
There was a problem hiding this comment.
FE-side is ok, I'd wait for BE-review before merging.
3 participants
Description
Changed UI fields according to new rules.
Changed validation logic in the backend.
Fixed browser and backend tests.
Related Issue(s)
HL-1706
Motivation and Context
Rules for benefit application changed in the beginning of 2026.
How Has This Been Tested?
Tests existed beforehand