feat(benefit): new states for application#3896
Conversation
ext-hjasplund
force-pushed
the
hl-1713-new-states
branch
2 times, most recently
from
2d68f2b to
19c6055
Compare
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😿💢💥💥 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3896.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😿💢💥💥 |
TestCafe result is success for https://helsinkilisa-ui-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3896.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😿💢💥💥 |
TestCafe result is success for https://helsinkilisa-ui-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
ext-hjasplund
force-pushed
the
hl-1713-new-states
branch
from
1eff204 to
6e701dc
Compare
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
ext-hjasplund
force-pushed
the
hl-1713-new-states
branch
from
26afab1 to
6e701dc
Compare
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3896.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
ext-hjasplund
force-pushed
the
hl-1713-new-states
branch
from
74546d2 to
91699a2
Compare
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3896.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3896.dev.hel.ninja 🚀🚀🚀 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 🚀🚀🚀 |
Added new states for the instalments. Added the colors for the instalments. Added a migration for instalments Added new statuses to language files Fixed the requested mode color Mode transitions in validator Ahjo integration label changed Refs: HL-1713, HL-1726
ext-hjasplund
force-pushed
the
hl-1713-new-states
branch
from
91699a2 to
63c32d8
Compare
TestCafe result is success for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
|
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3896.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3896.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3896.dev.hel.ninja 😆🎉🎉🎉 |
Added new applications to test fixtures. Refs: HL-1713
| COMPLETED = "completed", _("Completed") | ||
| REQUESTED = "requested", _("Requested") | ||
| RESPONDED = "responded", _("Responded") |
There was a problem hiding this comment.
Bug: A hardcoded list of instalment statuses in _get_application_pks_with_instalments was not updated with the new REQUESTED, RESPONDED, and PENDING statuses, causing applications to be hidden from handlers.
Severity: HIGH
Suggested Fix
Update the hardcoded list of statuses in the _get_application_pks_with_instalments method in backend/benefit/applications/api/v1/application_views.py to include the new REQUESTED, RESPONDED, and PENDING statuses. This will ensure applications with second instalments in these states remain visible to handlers.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: backend/benefit/calculator/enums.py#L44-L46
Potential issue: The method `_get_application_pks_with_instalments` in
`backend/benefit/applications/api/v1/application_views.py` uses a hardcoded list of
statuses to ensure applications with second instalments remain visible in the handler's
main view. This change introduces new instalment statuses (`REQUESTED`, `RESPONDED`,
`PENDING`) but fails to add them to this hardcoded list. As a result, if a second
instalment transitions to one of these new intermediate states, the application will be
incorrectly filtered out and hidden from the handler's view, preventing handlers from
processing these applications and breaking the workflow.
1 participant
Description
Added new states for the instalments.
Fixed "Ahjo kokeilu" text to "Ahjo-integration".
Related Issue(s)
HL-1713
HL-1726
Motivation and Context
New states for the application required.
How Has This Been Tested?
Test fixtures for new applications