Move ACT_MULTIPLE_BUILD, ACT_FETCH_REQUIRED, ACT_MULTIPLE_CONSTRUCTION to activity_actors #85135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "move ACT_MULTIPLE_BUTCHER, ACT_FETCH_REQUIRED, ACT_MULTIPLE_CONSTRUCTION to activity_actors"
Purpose of change
Update legacy activities.
Describe the solution
multi_activity_actornamespace functions tomulti_zone_activity_actor, and also fixes some consequences of multi-activities no longer calling static functions.orblocks into a JSON field.Describe alternatives you've considered
Also adds a TODO for making test case
act_multiple_constructioncheck for moving tools, because it always assumes that tools are in the player's inventory and missed the unreported error mentioned above.Testing
ACT_MULTIPLE_BUTCHER
Tested the following for butchering three chicken corpses in a Loot: Corpses Zone with a machete:
ACT_MULTIPLE_CONSTRUCTION
Tested the following for a "Build Door" Zone:
multiple-step construction activity with fetch requiredact_build_test.cpp, which also passes locally)ACT_FETCH_REQUIRED
Tested with ACT_MULTIPLE_CONSTRUCTION as above:
Additional context
Fixed 84289 message:
