Unification of need_charges_msg#85148
Merged
Maleclypse merged 1 commit intoCleverRaven:masterfrom Feb 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Standing-Storm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
(off)'sneed_charges_msg). The main issue is that these messages are too long and only appear in theactivation menu, where screen space is limited.Describe the solution
Replace all messages like
The %s's batteries are deadwithThe batteries are dead. This wording is independent of the item's name, shorter, and more readable.Minor related fixes:
Added the missing
ammo_scaletoshocktonfa, which prevented its flashlight from turning off when the battery died. Removed the unnecessaryneed_chargesrequirement, as turning the tonfa off does not require charge.Laptops use the same messages for lighting up the screen.
Describe alternatives you've considered
Maybe a different message wording? It will display for both a depleted and a missing battery.
Maybe use the singular form
The battery is dead.Testing
Additional context