Make flowers and DoublePlants break like vanilla

[kaniteru]

• Fix issue where items didn't drop when breaking the top part of tall grass
• Add particle effects were only played for the top/bottom parts when breaking tall grass

In vanilla, shears should consume durability when breaking grass and flowers; otherwise, they should not.

So,

• Overridden getToolType() and breakWhenPushed() in BlockFlower and BlockDoublePlant.
• Make durability not decrease when breaking grass and flowers with tools other than shears

[xRookieFight]

This empty if statement isn't well

[kaniteru]

@xRookieFight
Yes, I think so too. However, I'm not sure how to incorporate this condition while maintaining the existing coding style.

This is the optimal code I can think of is this:

@Override
public boolean useOn(Block block) {
    if (this.noDamageOnBreak() || this.isUnbreakable() || this.isDurable()) {
        return true;
    }
    
    if (block.getToolType() == ItemTool.TYPE_PICKAXE && this.isPickaxe() ||
            block.getToolType() == ItemTool.TYPE_SHOVEL && this.isShovel() ||
            block.getToolType() == ItemTool.TYPE_AXE && this.isAxe() ||
            block.getToolType() == ItemTool.TYPE_HOE && this.isHoe() ||
            block.getToolType() == ItemTool.TYPE_SWORD && this.isSword() ||
            block.getToolType() == ItemTool.TYPE_SHEARS && this.isShears()
            ) {
        this.meta++;
        return true;
    }
    
    if (this.isSword() && block.getHardness() > 0) {
        this.meta += 2;
        return true;
    }
    
    if (this.isHoe() && ((block.getId() == GRASS || block.getId() == DIRT))) {
        this.meta++;
        return true;
    }
    
    if (block.getId() == TALL_GRASS || block.getId() == FLOWER || block.getId() == DOUBLE_PLANT) {
        return true;
    }
    
    this.meta++;
    return true;
}

Or

int damage = 0;

...

this.meta += damage;
return true;

[kaniteru]

ahh, I didn't mean to rush you, sorry :/

[xRookieFight]

No worries 😄, the first one is more optimized for me. You can commit that

[kaniteru]

I hope I performed the push correctly

[xRookieFight]

Looks fine to me