Merged
Conversation
gabrielbmoro
commented
May 21, 2025
| type = ProjectType.KMP | ||
|
|
||
| children = listOf( | ||
| PopcornChildConfiguration( |
Author
There was a problem hiding this comment.
Core modules should not have internal dependencies
gabrielbmoro
commented
May 21, 2025
| ), | ||
| ), | ||
| PopcornChildConfiguration( | ||
| moduleNameRegex = ":feature-[a-z]+", |
Author
There was a problem hiding this comment.
Feature modules should not depend on another feature modules
gabrielbmoro
commented
May 21, 2025
| ), | ||
| ), | ||
| ), | ||
| ) |
Author
There was a problem hiding this comment.
@rviannaoliveira , is there any other rule we need to add?
We are in a good shape, popcorn is approving our architecture.
This commit refactors the PopcornPlugin configuration in `popcorngp-setup-plugin.gradle.kts`. The following changes were made: - Added new rules for `:core-shared-ui` to only depend on `:core-shared`. - Added new rules for `:core-shared` to have no dependencies. - Updated existing rules for feature modules to ensure they do not depend on each other.
rviannaoliveira
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Add popcorngp into the project
Testes Realizados
Checklist