Conversation
added 7 commits
May 24, 2025 18:55
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports
|
git-jr
force-pushed
the
feature/background-work
branch
from
18b27b6 to
0859232
Compare
gabrielbmoro
left a comment
gabrielbmoro
left a comment
There was a problem hiding this comment.
Just commenting a strategy that could improve the code readability
| implementation(libs.koin.core) | ||
| implementation(projects.coreShared) | ||
| implementation(projects.featureListStreams) | ||
| api(libs.kmpnotifier) |
There was a problem hiding this comment.
#question
Can we use implementation instead of api here?
Collaborator
Author
There was a problem hiding this comment.
I need to access the notifications lib in different modules (background, general and in the IOS APP), hence the use of the API
| import com.codandotv.streamplayerapp.core_background_work.SyncManager | ||
| import org.koin.dsl.module | ||
|
|
||
| object SyncModule { |
There was a problem hiding this comment.
Maybe it would be easier we have SyncManager as an interface, both implementations be defined at androidMain, and iosMain.
You can achieve that by using:
expect fun provideSyncManagerInstance(): SyncManager
val module = module { single { provideSyncManagerInstance() }In the androidMain, you can define an actual (the same on iOS).
gabrielbmoro
approved these changes
May 30, 2025
rviannaoliveira
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Testes Realizados
Manual testing on Android (physical device and emulator) and iOS (physical iPhone; not supported on simulator)
Screenshots
----Android
Backgorund-Work-Android.mp4
----iOS
Backgorund-Work-IOS.mp4
Checklist