Skip to content

Include links to original sources in success pages#1730

Merged
illicitonion merged 3 commits intomainfrom
success-page-links
Feb 5, 2026
Merged

Include links to original sources in success pages#1730
illicitonion merged 3 commits intomainfrom
success-page-links

Conversation

@illicitonion
Copy link
Member

This:

  • Makes it easier to see what things are self-study vs have expected evidence from backlog.
  • Makes it easier to link back to where the topics were introduced.

The way we go about this is:

  1. When fetching remote learning objectives, parse out to accumulate the list of LOs, rather than just grabbing the whole markdown block
  2. Pass LOs through a {{<objectives>}} shortcode, rather than just pulling the shortcode in through the raw markdown.
  3. Pass links to the original blocks into the rendering block.
  4. Send both local and remote learning objectives through the same rendering block (common-theme/layouts/partials/objectives/for-success.html) which now includes links back.

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 56dc121
🔍 Latest deploy log https://app.netlify.com/projects/cyf-launch/deploys/6984803e7d835b0008efcfbb
😎 Deploy Preview https://deploy-preview-1730--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 56dc121
🔍 Latest deploy log https://app.netlify.com/projects/cyf-common/deploys/6984803e424e460007913f76
😎 Deploy Preview https://deploy-preview-1730--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 56dc121
🔍 Latest deploy log https://app.netlify.com/projects/cyf-sdc/deploys/6984803e1338d60008bb78d8
😎 Deploy Preview https://deploy-preview-1730--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 56dc121
🔍 Latest deploy log https://app.netlify.com/projects/cyf-programming/deploys/6984803e03b0d10008657eeb
😎 Deploy Preview https://deploy-preview-1730--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 56dc121
🔍 Latest deploy log https://app.netlify.com/projects/cyf-curriculum/deploys/6984803e2fd7960008fe6046
😎 Deploy Preview https://deploy-preview-1730--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 56dc121
🔍 Latest deploy log https://app.netlify.com/projects/cyf-tracks/deploys/6984803e03976d000871c47a
😎 Deploy Preview https://deploy-preview-1730--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 56dc121
🔍 Latest deploy log https://app.netlify.com/projects/cyf-itd/deploys/6984803eb959e50008789600
😎 Deploy Preview https://deploy-preview-1730--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 56dc121
🔍 Latest deploy log https://app.netlify.com/projects/cyf-piscine/deploys/6984803e68c68a00086796fe
😎 Deploy Preview https://deploy-preview-1730--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

This:
* Makes it easier to see what things are self-study vs have expected
  evidence from backlog.
* Makes it easier to link back to where the topics were introduced.

The way we go about this is:
1. When fetching remote learning objectives, parse out to accumulate the
   list of LOs, rather than just grabbing the whole markdown block
2. Pass LOs through a `{{<objectives>}}` shortcode, rather than just
   pulling the shortcode in through the raw markdown.
3. Pass links to the original blocks into the rendering block.
4. Send both local and remote learning objectives through the same
   rendering block (`common-theme/layouts/partials/objectives/for-success.html`)
   which now includes links back.
@illicitonion
Copy link
Member Author

Copy link
Contributor

@cifarquhar cifarquhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 👀 In review in Curriculum Planning Feb 3, 2026
@cifarquhar
Copy link
Contributor

A follow-up thought that occurred while editing backlogs: these success criteria are capturing optional items too, eg. Stretch Codewars Katas in this sprint. Maybe not a question for this issue, but do we want to include the stretch goals? It risks presenting something optional as if it were mandatory.

@illicitonion
Copy link
Member Author

A follow-up thought that occurred while editing backlogs: these success criteria are capturing optional items too, eg. Stretch Codewars Katas in this sprint. Maybe not a question for this issue, but do we want to include the stretch goals? It risks presenting something optional as if it were mandatory.

Yeah it's an interesting one. It does have Stretch in its title - maybe that's enough? Or maybe we want to group the stretch things after a "Stretch" heading?

Implenetation-wise, though, I'm tempted to literally just grep the title for "Stretch", I don't think we currently want to build any more complex prioritising logic into the curriculum.

@OracPrime
Copy link
Contributor

Am I the only one that ticked all the boxes to see if there was a done effect (not disappointed) ? Although it is not immediately obvious that they are interactive tick marks.
I'm not sure I'm a huge fan of the Backlog etc hyperlinks. There are well-established UI conventions for hyperlinks and I'm not sure a green shadow which disappears when you hover over it is on the list. There a places for creativity, and others for convention.
Neither of these points is a showstopper though

@illicitonion
Copy link
Member Author

Am I the only one that ticked all the boxes to see if there was a done effect (not disappointed) ? Although it is not immediately obvious that they are interactive tick marks.

Yeah, it's more of an easter egg than a key feature (though we do generally demonstrate this when showing off the curriculum to people for the first time)

I'm not sure I'm a huge fan of the Backlog etc hyperlinks. There are well-established UI conventions for hyperlinks and I'm not sure a green shadow which disappears when you hover over it is on the list. There a places for creativity, and others for convention.

This is our "button" style, rather than our "link" style. I've re-styled them as links rather than buttons, WDYT?

@illicitonion illicitonion merged commit 9d230a9 into main Feb 5, 2026
35 checks passed
@illicitonion illicitonion deleted the success-page-links branch February 5, 2026 11:53
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Curriculum Planning Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants