Skip to content

fix(bug): use stream when downloading snapshot locally #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KeiKey merged 2 commits into from
May 12, 2025
Merged

fix(bug): use stream when downloading snapshot locally #223

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c17d4b4
fix(bug): use stream when downloading snapshot locally
Apr 17, 2025
08f1aa6
fix: await snapshot file write completion
May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/lib/snapshots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,14 @@ export const createSnapshot = async (
spinner.setSpinnerTitle(`Downloading Snapshot ... %s`);
const snapshotFile = (
await axios.get(downloadLink.downloadLink, {
responseType: 'arraybuffer',
responseType: 'stream',
})
).data;

fs.writeFileSync(snapshotDir + '/' + snap.name + '.csnap', snapshotFile);
const writer = fs.createWriteStream(
snapshotDir + '/' + snap.name + '.csnap'
);
snapshotFile.pipe(writer);
}

spinner.stop();
Expand Down
Loading