Fix: model download fails when server defaults to gzip#242
Fix: model download fails when server defaults to gzip#242ansonkao wants to merge 2 commits intoComfy-Org:mainfrom
Conversation
|
Confirming this resolved an issue I had with a CDN I was downloading files from |
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Hi, thanks for the PR and for sharing your fix. I have some reservations about forcing Technically, gzip shouldn't make downloads slower; the server should understand and choose if the compression should take place or not. Could you please share a URL that lets us reproduce the problem? I am just worried about merging a fix for a specific case that could slow things down for everyone else. |
gzip breaks Content-Length and makes downloads slower.
Content-Length is expected by the progress-bar logger in download_file()