feat(manager): add ComfyUI-Manager v4 support #363
Open
Conversation
dosubot
bot
added
size:XXL
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 52.48% 56.12% +3.64%
==========================================
Files 32 32
Lines 3563 3720 +157
==========================================
+ Hits 1870 2088 +218
+ Misses 1693 1632 -61
🚀 New features to boost your workflow:
|
ltdrdata
force-pushed
the
feat/support-manager-v4
branch
2 times, most recently
from
88530dc to
c29f340
Compare
ComfyUI-Manager v4 is now installed as a pip package (via
manager_requirements.txt) rather than being git-cloned into custom_nodes/.
Breaking Changes:
- Remove --manager-url and --manager-commit options from install command
- validate_comfyui_manager() now uses find_cm_cli() instead of git path check
Manager Subcommand Changes:
- Add 'disable' command: disable manager completely (no flags passed)
- Add 'enable-gui' command: enable manager with new GUI
- Add 'disable-gui' command: enable manager but disable GUI only
- Add 'enable-legacy-gui' command: enable manager with legacy GUI
- Add 'migrate-legacy' command: migrate git-cloned manager to pip package
Implementation:
- find_cm_cli() uses importlib.util.find_spec("cm_cli") with @lru_cache
- execute_cm_cli() uses module-based execution (python -m cm_cli)
- _get_manager_flags() injects flags based on config mode
- Add 34 tests covering manager v4 scenarios
ltdrdata
force-pushed
the
feat/support-manager-v4
branch
from
c29f340 to
b7d0a07
Compare
…idation - Add TestFillPrintTable covering all GUI mode states and backward compatibility - Add TestFindCmCli for cm_cli module detection and caching behavior - Add TestPipInstallManagerEdgeCases for missing requirements file - Add TestValidateComfyuiManager for cm-cli validation flow
- Fix string/boolean comparison in _get_manager_flags() and fill_print_table() - Support "false", "0", "off" and "true", "1", "on" variations - Add stderr capture and output for pip install failures - Add tests for boolean backward compatibility - Improve test assertions for cache_clear and subprocess commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComfyUI-Manager v4 is now installed as a pip package (via
manager_requirements.txt) rather than being git-cloned intocustom_nodes/.Breaking Changes
--manager-urland--manager-commitoptions from install commandvalidate_comfyui_manager()now usesfind_cm_cli()instead of git path checkManager Subcommand Changes
comfy manager disablecomfy manager enable-guicomfy manager disable-guicomfy manager enable-legacy-guicomfy manager migrate-legacyImplementation Details
find_cm_cli()usesimportlib.util.find_spec("cm_cli")with@lru_cacheexecute_cm_cli()uses module-based execution (python -m cm_cli)_get_manager_flags()injects--enable-managerflags based on config modeReference: Comfy-Org/ComfyUI#12140