Recreate missing ComfyUI directories during validation#1428
Recreate missing ComfyUI directories during validation#1428benceruleanlu wants to merge 4 commits intomainfrom
Conversation
christian-byrne
left a comment
There was a problem hiding this comment.
How about tests?
This reverts commit 4cfa033.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
| installation = new ComfyInstallation('installed', basePath, telemetry); |
There was a problem hiding this comment.
Reset mock implementation between tests
The second test replaces createComfyDirectories with a throwing implementation (lines 77‑80), but the beforeEach only calls vi.clearAllMocks (lines 62‑64), which clears call history without restoring implementations. As a result, the third test still uses the throwing mock and will fail before reaching isComfyDirectory, so the new suite is red as soon as the failing mock is set. Reset the mock implementation (e.g., mockReset/resetAllMocks) or reassign it per test so the later cases run with the intended behavior.
Useful? React with 👍 / 👎.
|
This one isn't blocking for next release, so I'll draft until it's ready |
Summary
Context
User deleted the entire base path folder (~/Documents), leaving no
user/input/output/custom_nodes/modelsdirs. The app still validated as installed and tried to launch with--user-directory /Users/ben/Documents/user, which failed with:This change makes validation rebuild the directory structure and fail fast if it cannot, avoiding the runtime crash.
Testing