Skip to content

Revert "Bump PyTorch to 2.10.0" #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kosinkadink wants to merge 1 commit into from
Closed

Revert "Bump PyTorch to 2.10.0" #1569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 21 additions & 24 deletions assets/requirements/macos.compiled
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file was autogenerated by uv via the following command:
# uv pip compile assets/ComfyUI/requirements.txt assets/ComfyUI/manager_requirements.txt --emit-index-annotation --emit-index-url --index-strategy unsafe-best-match --python-platform aarch64-apple-darwin --python-version 3.12 --override assets/override.txt --index-url https://pypi.org/simple -o assets/requirements/macos.compiled
--index-url https://pypi.org/simple
--extra-index-url https://download.pytorch.org/whl/cu130
--extra-index-url https://download.pytorch.org/whl/cu129

aiohappyeyeballs==2.4.3
# via aiohttp
Expand All @@ -21,7 +21,7 @@ annotated-types==0.7.0
attrs==24.2.0
# via aiohttp
# from https://pypi.org/simple
av==16.1.0
av==14.3.0
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
certifi==2024.8.30
Expand All @@ -41,31 +41,28 @@ charset-normalizer==3.4.0
click==8.1.7
# via typer
# from https://pypi.org/simple
comfy-kitchen==0.2.7
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-embedded-docs==0.4.0
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-manager==4.0.5
comfyui-manager==4.0.3b7
# via -r assets/ComfyUI/manager_requirements.txt
# from https://pypi.org/simple
comfyui-workflow-templates==0.8.14
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-workflow-templates-core==0.3.100
comfyui-workflow-templates-core==0.3.58
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-api==0.3.44
comfyui-workflow-templates-media-api==0.3.31
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-image==0.3.66
comfyui-workflow-templates-media-image==0.3.43
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-other==0.3.87
comfyui-workflow-templates-media-other==0.3.61
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-video==0.3.39
comfyui-workflow-templates-media-video==0.3.22
# via comfyui-workflow-templates
# from https://pypi.org/simple
cryptography==43.0.3
Expand All @@ -84,7 +81,7 @@ filelock==3.16.1
# huggingface-hub
# torch
# transformers
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
frozenlist==1.5.0
# via
# aiohttp
Expand All @@ -94,7 +91,7 @@ fsspec==2024.10.0
# via
# huggingface-hub
# torch
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
gitdb==4.0.11
# via gitpython
# from https://pypi.org/simple
Expand All @@ -117,7 +114,7 @@ idna==3.10
# from https://pypi.org/simple
jinja2==3.1.4
# via torch
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
kornia==0.7.4
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
Expand All @@ -140,15 +137,15 @@ mdurl==0.1.2
# from https://pypi.org/simple
mpmath==1.3.0
# via sympy
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
multidict==6.1.0
# via
# aiohttp
# yarl
# from https://pypi.org/simple
networkx==3.4.2
# via torch
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
numpy==2.1.3
# via
# -r assets/ComfyUI/requirements.txt
Expand All @@ -157,7 +154,7 @@ numpy==2.1.3
# torchsde
# torchvision
# transformers
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
packaging==24.2
# via
# huggingface-hub
Expand All @@ -168,7 +165,7 @@ pillow==11.0.0
# via
# -r assets/ComfyUI/requirements.txt
# torchvision
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
propcache==0.3.1
# via
# aiohttp
Expand Down Expand Up @@ -257,9 +254,9 @@ sqlalchemy==2.0.41
# -r assets/ComfyUI/requirements.txt
# alembic
# from https://pypi.org/simple
sympy==1.14.0
sympy==1.13.1
# via torch
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
tokenizers==0.22.1
# via
# -r assets/ComfyUI/requirements.txt
Expand All @@ -268,7 +265,7 @@ tokenizers==0.22.1
toml==0.10.2
# via comfyui-manager
# from https://pypi.org/simple
torch==2.10.0
torch==2.5.1
# via
# --override assets/override.txt
# -r assets/ComfyUI/requirements.txt
Expand All @@ -278,7 +275,7 @@ torch==2.10.0
# torchsde
# torchvision
# from https://pypi.org/simple
torchaudio==2.10.0
torchaudio==2.5.1
# via
# --override assets/override.txt
# -r assets/ComfyUI/requirements.txt
Expand All @@ -288,7 +285,7 @@ torchsde==0.2.6
# --override assets/override.txt
# -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
torchvision==0.25.0
torchvision==0.20.1
# via
# --override assets/override.txt
# -r assets/ComfyUI/requirements.txt
Expand Down Expand Up @@ -324,7 +321,7 @@ typing-extensions==4.12.2
# torch
# typer
# typing-inspection
# from https://download.pytorch.org/whl/cu130
# from https://download.pytorch.org/whl/cu129
typing-inspection==0.4.0
# via
# pydantic
Expand Down
23 changes: 10 additions & 13 deletions assets/requirements/windows_cpu.compiled
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,31 +45,28 @@ colorama==0.4.6
# click
# tqdm
# from https://pypi.org/simple
comfy-kitchen==0.2.7
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-embedded-docs==0.4.0
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-manager==4.0.5
comfyui-manager==4.0.3b7
# via -r assets/ComfyUI/manager_requirements.txt
# from https://pypi.org/simple
comfyui-workflow-templates==0.8.14
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-workflow-templates-core==0.3.100
comfyui-workflow-templates-core==0.3.58
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-api==0.3.44
comfyui-workflow-templates-media-api==0.3.31
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-image==0.3.66
comfyui-workflow-templates-media-image==0.3.43
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-other==0.3.87
comfyui-workflow-templates-media-other==0.3.61
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-video==0.3.39
comfyui-workflow-templates-media-video==0.3.22
# via comfyui-workflow-templates
# from https://pypi.org/simple
cryptography==44.0.0
Expand Down Expand Up @@ -264,7 +261,7 @@ sqlalchemy==2.0.41
# -r assets/ComfyUI/requirements.txt
# alembic
# from https://pypi.org/simple
sympy==1.14.0
sympy==1.13.1
# via torch
# from https://pypi.org/simple
tokenizers==0.22.1
Expand All @@ -275,7 +272,7 @@ tokenizers==0.22.1
toml==0.10.2
# via comfyui-manager
# from https://pypi.org/simple
torch==2.10.0
torch==2.6.0
# via
# -r assets/ComfyUI/requirements.txt
# kornia
Expand All @@ -284,13 +281,13 @@ torch==2.10.0
# torchsde
# torchvision
# from https://pypi.org/simple
torchaudio==2.10.0
torchaudio==2.6.0
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
torchsde==0.2.6
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
torchvision==0.25.0
torchvision==0.21.0
# via
# -r assets/ComfyUI/requirements.txt
# spandrel
Expand Down
21 changes: 9 additions & 12 deletions assets/requirements/windows_nvidia.compiled
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,31 +46,28 @@ colorama==0.4.6
# click
# tqdm
# from https://download.pytorch.org/whl/cu130
comfy-kitchen==0.2.7
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-embedded-docs==0.4.0
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-manager==4.0.5
comfyui-manager==4.0.4
# via -r assets/ComfyUI/manager_requirements.txt
# from https://pypi.org/simple
comfyui-workflow-templates==0.8.14
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-workflow-templates-core==0.3.100
comfyui-workflow-templates-core==0.3.61
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-api==0.3.44
comfyui-workflow-templates-media-api==0.3.34
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-image==0.3.66
comfyui-workflow-templates-media-image==0.3.43
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-other==0.3.87
comfyui-workflow-templates-media-other==0.3.62
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-video==0.3.39
comfyui-workflow-templates-media-video==0.3.22
# via comfyui-workflow-templates
# from https://pypi.org/simple
cryptography==44.0.0
Expand Down Expand Up @@ -276,7 +273,7 @@ tokenizers==0.22.1
toml==0.10.2
# via comfyui-manager
# from https://pypi.org/simple
torch==2.10.0+cu130
torch==2.9.1+cu130
# via
# --override assets/override.txt
# -r assets/ComfyUI/requirements.txt
Expand All @@ -286,7 +283,7 @@ torch==2.10.0+cu130
# torchsde
# torchvision
# from https://download.pytorch.org/whl/cu130
torchaudio==2.10.0+cu130
torchaudio==2.9.1+cu130
# via
# --override assets/override.txt
# -r assets/ComfyUI/requirements.txt
Expand All @@ -296,7 +293,7 @@ torchsde==0.2.6
# --override assets/override.txt
# -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
torchvision==0.25.0+cu130
torchvision==0.24.1+cu130
# via
# --override assets/override.txt
# -r assets/ComfyUI/requirements.txt
Expand Down
4 changes: 2 additions & 2 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ export const AMD_TORCH_PACKAGES: string[] = [
'https://repo.radeon.com/rocm/windows/rocm-rel-7.1.1/torchvision-0.24.0+rocmsdk20251116-cp312-cp312-win_amd64.whl',
];

export const NVIDIA_TORCH_VERSION = '2.10.0+cu130';
export const NVIDIA_TORCHVISION_VERSION = '0.25.0+cu130';
export const NVIDIA_TORCH_VERSION = '2.9.1+cu130';
export const NVIDIA_TORCHVISION_VERSION = '0.24.1+cu130';
export const NVIDIA_TORCH_PACKAGES: string[] = [
`torch==${NVIDIA_TORCH_VERSION}`,
`torchaudio==${NVIDIA_TORCH_VERSION}`,
Expand Down
4 changes: 2 additions & 2 deletions src/install/installationManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { promisify } from 'node:util';

import { strictIpcMain as ipcMain } from '@/infrastructure/ipcChannels';

import { IPC_CHANNELS, InstallStage, NVIDIA_TORCH_VERSION, ProgressStatus } from '../constants';
import { IPC_CHANNELS, InstallStage, ProgressStatus } from '../constants';
import { PythonImportVerificationError } from '../infrastructure/pythonImportVerificationError';
import { useAppState } from '../main-process/appState';
import type { AppWindow } from '../main-process/appWindow';
Expand Down Expand Up @@ -408,7 +408,7 @@ export class InstallationManager implements HasTelemetry {
await this.appWindow.showMessageBox({
type: 'warning',
title: 'Update NVIDIA Driver',
message: `Your NVIDIA driver may be too old for PyTorch ${NVIDIA_TORCH_VERSION}.`,
message: 'Your NVIDIA driver may be too old for PyTorch 2.9.1 + cu130.',
detail: `Detected driver version: ${driverVersion}\nRecommended minimum: ${NVIDIA_DRIVER_MIN_VERSION}\n\nPlease consider updating your NVIDIA drivers and retrying if you run into issues.`,
buttons: ['OK'],
});
Expand Down
Loading