fix: ao stop logs accurate dashboard status#131
Open
AgentWrapper wants to merge 1 commit intomainfrom
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Extract stopDashboard to lib/stop-dashboard.ts so it can be tested in isolation. The function already correctly logs "Dashboard stopped" when processes are killed and "Dashboard not running on port X" when nothing is found. Add tests to prevent regression. Fixes #92. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AgentWrapper
force-pushed
the
fix/stop-logs-accuracy
branch
from
f95a59d to
111c43c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| beforeEach(() => { | ||
| mockExec.mockReset(); | ||
| vi.spyOn(console, "log").mockImplementation(() => {}); | ||
| }); |
There was a problem hiding this comment.
Missing afterEach mock restoration breaks test codebase pattern
Low Severity
Every other test file in packages/cli/__tests__/ imports afterEach and calls vi.restoreAllMocks() to clean up spies (e.g., dashboard.test.ts, init.test.ts, open.test.ts, session.test.ts). This new test file creates a console.log spy in beforeEach but never restores it. The spy's call history accumulates across tests since neither mockClear nor mockReset is called on it, making negative assertions like not.toHaveBeenCalledWith fragile and order-dependent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stopDashboardfromstart.tsintolib/stop-dashboard.tsfor testability"Dashboard stopped"(green) when processes are killed, or"Dashboard not running on port X"(yellow) when nothing is found — fixes the regression where it always logged "Dashboard stopped"__tests__/commands/start.test.tswith 4 tests covering all branchesFixes #92.
Test plan
ao stopwhen dashboard is running → logsDashboard stoppedin greenao stopwhen dashboard is not running → logsDashboard not running on port Xin yellowpnpm exec vitest run __tests__/commands/start.test.tsinpackages/cli— 4 tests pass🤖 Generated with Claude Code