ref(angularx-qrcode.component.ts): prevent qr regeneration on accessi…#280
Open
ali-toghiani wants to merge 4 commits intoCordobo:mainfrom
Open
ref(angularx-qrcode.component.ts): prevent qr regeneration on accessi…#280ali-toghiani wants to merge 4 commits intoCordobo:mainfrom
ali-toghiani wants to merge 4 commits intoCordobo:mainfrom
Conversation
…bility input changes
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the QR code regeneration process by implementing selective change detection in the ngOnChanges lifecycle hook. Instead of regenerating the QR code on every input change, it now only regenerates when inputs that actually affect the visual appearance change.
- Introduces selective change detection to prevent unnecessary QR code regeneration
- Separates visual changes from accessibility attribute updates for better performance
- Refactors accessibility attribute setting into a reusable method
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Author
|
Hi @Cordobo, I’ve addressed the feedback from Copilot in the recent commits. Please let me know if there’s anything else needed to move this PR forward or if you’re waiting on additional reviews. Happy to assist with any further changes! Thanks for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #279
ngOnchanges checks input changes and only regenerates the qr if inputs that effect QR generation has changed.