Merged
Conversation
joanagmaia
requested changes
Jan 30, 2026
Contributor
|
@ulemons code scanning is failing 🤔 might be worth checking it out |
Contributor
Author
|
@joanagmaia yes i have seen that issue but they are not related to any of the file i have modified, should i fix them anyway ? they are about some limit constraint and some vulnerable regex expressions |
Contributor
|
@ulemons let's then create a task for it, and merge this one just so it's not blocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: People List Not Updating After Operations
Problem
The people list was not refreshing properly after performing operations like marking members as bot, marking as team member, or deleting profiles. This caused data inconsistency and a poor user experience.
Solution
1. Include All Attributes to Prevent Data Loss
includeAllAttributesparameter to fetch complete member data before updatesisBot,isTeamMember)2. Backend Cache Invalidation Control
invalidateCacheparameter to the backendMemberService.update()methodinvalidateCache: false) invalidates only the specific member's cacheinvalidateCache: true, also invalidates all list caches to ensure consistency across all users3. Simplified Frontend Query Invalidation
queryClient.invalidateQueries()after operations to refresh the UI4. Optimized Backend Calls
Benefits
Note
Medium Risk
Touches member read/update flows and Redis cache invalidation behavior; incorrect cache-keying or invalidation could cause stale data or elevated cache churn, but changes are scoped and opt-in via new flags.
Overview
Ensures the People list refreshes reliably after member updates/deletes by switching UI refresh to TanStack Query invalidation and clearing bulk selections after actions.
Adds safer attribute updates for mark as team member/mark as bot by first fetching the member with
includeAllAttributesto avoid overwriting attributes, and introduces a new bulk "Mark as bot" action.Extends the backend member APIs to accept
includeAllAttributesonGET /member/:idandinvalidateCacheonPUT /member/:id, and updates member query caching to (a) includeincludeAllAttributesin cache keys and (b) optionally invalidate all list caches when requested (used for delete/unmerge and selected updates).Written by Cursor Bugbot for commit 6aef904. This will update automatically on new commits. Configure here.