Skip to content

[FIX] Correct currency comparison in _compute_amount of sale_discount_total #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G02-Manuel wants to merge 2 commits into
base: 17.0
Choose a base branch
from
Open

[FIX] Correct currency comparison in _compute_amount of sale_discount_total #411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
301fdaf
[FIX] Correct payment_state for invoices with foreign currency
G02-Manuel Jan 29, 2026
8755b31
{FIX] Prevent division by zero when deleting all invoice lines
G02-Manuel Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sale_discount_total/models/account_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def _compute_amount(self):
else:
new_pmt_state = move._get_invoice_in_payment_state()
elif currency.compare_amounts(total_to_pay,
abs(total_residual)) != 0:
abs(total_residual_currency)) != 0:
new_pmt_state = 'partial'
if new_pmt_state == 'paid' and move.move_type in (
'in_invoice', 'out_invoice', 'entry'):
Expand Down Expand Up @@ -164,10 +164,10 @@ def _supply_rate(self):
total = 0.0
for line in inv.invoice_line_ids:
total += (line.quantity * line.price_unit)
if inv.discount_rate != 0:
if inv.discount_rate != 0 and total != 0:
discount = (inv.discount_rate / total) * 100
else:
discount = inv.discount_rate
discount = inv.discount_rate if total == 0 else 0
for line in inv.invoice_line_ids:
line.discount = discount
inv.amount_discount = inv.discount_rate
Expand Down