Add support for global synonym/curation sets (Typesense v30+)#304
Open
WimVergouwe wants to merge 5 commits intoDAXGRID:masterfrom
Open
Add support for global synonym/curation sets (Typesense v30+)#304WimVergouwe wants to merge 5 commits intoDAXGRID:masterfrom
WimVergouwe wants to merge 5 commits intoDAXGRID:masterfrom
Conversation
Contributor
WimVergouwe
commented
Jan 29, 2026
WimVergouwe
commented
- Add global synonym set and curation set APIs to ITypesenseClient
- Add new record types for synonym/curation set schemas and responses
- Update CollectionResponse and Schema for synonym_sets/curation_sets
- Add compatibility/version logic to Config and TypesenseClient
- Enforce feature support at runtime with NotSupportedException
- Update and expand tests for new APIs, using SkippableFact
- Allow test fixture to configure minimum compatibility version
- Miscellaneous test and error handling improvements
- Add global synonym set and curation set APIs to ITypesenseClient - Add new record types for synonym/curation set schemas and responses - Update CollectionResponse and Schema for synonym_sets/curation_sets - Add compatibility/version logic to Config and TypesenseClient - Enforce feature support at runtime with NotSupportedException - Update and expand tests for new APIs, using SkippableFact - Allow test fixture to configure minimum compatibility version - Miscellaneous test and error handling improvements
dejonghee
approved these changes
Jan 29, 2026
Member
|
Hi @WimVergouwe, I am currently a bit busy IRL, but hopefully I can do a review soon. Thanks, |
Member
|
Hi @WimVergouwe, Thank you for the contribution. I've reviewed a few things so far, and I think it looks good. I think I would rather we do not introduce the version check, and I'll jump bump it to be a new major version. I think the complexity added does not add enough benefit. If you can remove that I'll take another look after. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.