-
Notifications
You must be signed in to change notification settings - Fork 3
Add reuse seeds and helper #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericaporter
wants to merge
11
commits into
main
Choose a base branch
from
create-reuse-seeds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+678
−1
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
93b4ea5
Add reuse seeds and helper
ericaporter 8ea0a42
Tidy reuse_choices.rb
ericaporter a2c67e3
Update AB block
ericaporter 3fc17e3
Update AB in seeds
ericaporter 2ae0dfa
Update seeds helper
ericaporter f07b1cb
Target AB CI failures
ericaporter 0acb404
Update AB method
ericaporter 275e3ad
Update seeds to include AppropriateBodyPeriods
ericaporter 49d38f5
Update out of sync db & specs
ericaporter b24705e
Fix ReuseChoices seeds to consistently use Golden Leaf ABP and ensure…
ericaporter 8091958
Tidy reuse_choices
ericaporter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| if Rails.env.staging? || Rails.env.development? || Rails.env.review? | ||
| require Rails.root.join("db/seeds/support/seeds/reuse_choices") | ||
|
|
||
| print_seed_info( | ||
| "Seeding reuse choices scenario schools (staging only)", | ||
| colour: :yellow, | ||
| blank_lines_before: 1 | ||
| ) | ||
|
|
||
| Seeds::ReuseChoices.new(contract_period_year: 2025).call | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update to
if Rails.env.staging?before merging (otherwise can't test seeds)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, do you know why we want different seeds on staging compared to review etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to double-check with Emily!