Conversation
7cab612 to
0b35072
Compare
|
So I applied b830754 to test the content of the PR on my fork. It seems to work:
Note: |
afd00ac to
714db7c
Compare
|
I've applied the latest changes, and made things a bit differently in It allows testing potential changes that could occur in the |
|
Looks like I don't have enough space to run I am trying to add a |
|
I've applied DIRACGrid/diracx-charts#158 to this PR, and it seems to solve the issue. |
4b1d400 to
bd0f6e3
Compare
|
|
bd0f6e3 to
a2f221d
Compare
5d195dd to
923ba11
Compare
3232bab to
1f81e2e
Compare
0dd6186 to
40cd3d0
Compare
40cd3d0 to
38db73d
Compare
|
I just rebased my PR and adapted it based on the latest changes. |
Closes #349
I could potentially create a reusable workflow to avoid duplicating some code between
deployment.yamlandextension.yamlbut this would also add some complexity toextension.yaml. As it can act as an example of CI, I feel like it should stay clear and simple and that we can afford that small duplication (I've tried to minimize it). Please let me know if you have a different opinion.Here I export both
gubbins/clientandservices, but I think we would just need to usegubbins/services.Unless you disagree, or if you have a better plan, I will make a quick test on my repo first, and if everything goes well I undraft the PR.