Open
Conversation
holke
requested changes
Nov 27, 2025
Collaborator
holke
left a comment
There was a problem hiding this comment.
Please merge with main and see if you can get the tests running.
Collaborator
|
This branch is stalled a bit. However we are further progressing on the FetchContent-Approach with GoogleTest. It would be nice to have the option to use the FetchContent Approach for sc & p4est as well. |
required to use cmake to parse json-file
descripe dependency in a json-file, where each dependency is parsed from. Optional provide information to a cmake-flag, if the content should not be loaded via fetchContent but using some other logic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
=======================================
Coverage 77.95% 77.95%
=======================================
Files 113 113
Lines 19089 19089
=======================================
Hits 14881 14881
Misses 4208 4208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1723
Describe your changes here:
This PR changes the way how we integrate our submodules. We switch from git submodule to cmake's FetchContent. With this sc and p4est are automatically downloaded when cmake is run the first time.
UPDATE: I also changed that creation of p4est. The release installation of p4est did not link against the release version of sc. I changed it, such that the installation of p4est in release mode links against sc in release mode.
ToDo:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).