Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
=======================================
Coverage 77.95% 77.95%
=======================================
Files 113 113
Lines 19087 19087
=======================================
Hits 14880 14880
Misses 4207 4207 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
lenaploetzke
left a comment
There was a problem hiding this comment.
First part of review
Typos Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Collaborator
lenaploetzke
left a comment
There was a problem hiding this comment.
Please also merge main
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
lenaploetzke
reviewed
Feb 4, 2026
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
lenaploetzke
approved these changes
Feb 4, 2026
Collaborator
lenaploetzke
left a comment
There was a problem hiding this comment.
I think it is fine now, thanks for the work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2074
Describe your changes here:
I am so sorry for the diff count. But a huge part of this PR is documentation.
Fixes a bug in our curved mesh algorithms in which in some edge cases geometries were either not linked to tree faces or they were linked with wrong parameters. This can be observed by executing the curved mesh tutorial for tetrahedra on main and on this branch.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).