Skip to content

Bugfix: Curved geometries#2073

Merged
lenaploetzke merged 24 commits intomainfrom
fix-curved_geometries
Feb 4, 2026
Merged

Bugfix: Curved geometries#2073
lenaploetzke merged 24 commits intomainfrom
fix-curved_geometries

Conversation

@sandro-elsweijer
Copy link
Member

@sandro-elsweijer sandro-elsweijer commented Jan 9, 2026

Closes #2074

Describe your changes here:
I am so sorry for the diff count. But a huge part of this PR is documentation.
Fixes a bug in our curved mesh algorithms in which in some edge cases geometries were either not linked to tree faces or they were linked with wrong parameters. This can be observed by executing the curved mesh tutorial for tetrahedra on main and on this branch.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer self-assigned this Jan 9, 2026
@sandro-elsweijer sandro-elsweijer changed the title Bugfic: Curved geometries Bugfix: Curved geometries Jan 12, 2026
@sandro-elsweijer sandro-elsweijer removed their assignment Jan 13, 2026
@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review January 13, 2026 14:39
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.95%. Comparing base (d7259da) to head (0b7c511).
⚠️ Report is 65 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2073   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files         113      113           
  Lines       19087    19087           
=======================================
  Hits        14880    14880           
  Misses       4207     4207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part of review

Copy link
Collaborator

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also merge main

sandro-elsweijer and others added 4 commits February 3, 2026 13:19
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
@sandro-elsweijer sandro-elsweijer removed their assignment Feb 3, 2026
sandro-elsweijer and others added 6 commits February 4, 2026 14:18
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
Copy link
Collaborator

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine now, thanks for the work!

@lenaploetzke lenaploetzke added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit 5abe3c8 Feb 4, 2026
40 checks passed
@sandro-elsweijer sandro-elsweijer deleted the fix-curved_geometries branch February 4, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugfic: Curved geometries

2 participants