Add Functionality Allowing Super Admins to Confirm/Unconfirm User Emails#3535
Open
aaronskiba wants to merge 9 commits intoDMPRoadmap:developmentfrom
Open
Conversation
This change addresses an issue where some users reported not receiving the confirmation instructions email. Rather than having to manually update the users email confirmation status within the Rails console, this change allows users to confirm/unconfirm user emails within the app.
`spec/controllers/super_admin/users_controller_spec.rb`: - Added test to prevent un-confirming of any super admin email within app `app/controllers/super_admin/users_controller.rb`: - Added !@user.can_super_admin? check to enable the aforementioned test to pass - Also, updated a `patch` statement to `put`
Improves UX and reduces confusion when updating a user's email confirmation status. - Moved confirmation status inline with the "Email status:" heading - Updated checkbox helper text to reflect current @user.confirmed? state: - Shows "(Check to confirm email)" if unconfirmed - Shows "(Uncheck to unconfirm email)" if confirmed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (Issue exists downstream: portagenetwork#1006)
Changes proposed in this PR:
/super_admin/users/:idpath.@portagenetwork.ca, and as a result, preventing users from receiving email confirmation instructions.