Make 'id's unique in PaginationComponent#2836
Make 'id's unique in PaginationComponent#2836mwoodiupui wants to merge 3 commits intoDSpace:mainfrom
Conversation
|
Hi @mwoodiupui, |
|
Hi @mwoodiupui, |
0efe031 to
caaa37a
Compare
|
Hi @mwoodiupui, |
|
"Help wanted" because I need some advice on how to make the specs work. |
|
Hi @mwoodiupui, |
|
This pull request has been automatically marked as stale because it has not had Allowing pull requests to close as stale helps us filter out old work that is no longer All pull requests closed by this bot act like normal pull requests; If these changes are still relevant then please comment and/or rebase your PR based on the |
5cf389a to
1dda0a8
Compare
Description
When displaying a Community with both child Collections and sub-Communities, the pagination controls for the two lists will have duplicate
idattributes. SiteImprove considers this an accessibility issue. This patch generates a UUID member in PaginationComponent and uses it in the template to make theids unique.Instructions for Reviewers
To test, you will need a Community with child Collections and sub-Communities, so that both lists appear.
List of changes in this PR:
elementIdfield, which is initialized to a UUID in the constructor.idattributes as appropriate..specis updated to provide UUIDService for injection.NOTE: the
.specis broken: "NullInjectorError: No provider for UUIDService!"NOTE: after the above is fixed, the
.specwill probably fail because it is looking for fixed attribute values. I will work on that after the suite is repaired enough to run at all.Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.