[DSpace-CRIS] Porting of authority framework functionalities (Frontend) by FrancescoMolinaro · Pull Request #4956 · DSpace/dspace-angular

FrancescoMolinaro · 2025-12-19T11:28:08Z

References

Fixes [DSpace-CRIS] Data model preparation work (Authority Framework enhancements, etc) DSpace#11748
Requires backend PR: [DSpace-CRIS] Porting of authority framework functionalities (Backend) DSpace#11718
Relates to: [DSpace-CRIS] Creation of a custom URL for Items (Frontend) #4814

Description

Initial port of the DSpace-CRIS authority framework into core DSpace, enabling real-time entity lookup, confidence-based linking, and automatic graph maintenance through server-side consumers.

On the UI this PR introduces a new way to link authorithy controlled metadata to the related item, generating a link in search results or item page, this connection is handled in submission. (for configuration check the rest PR)

Through a rest configuration, is possible also to activate an "auto-fill" functionality, that will populate the submission fields based on the selected value (value must be authority controlled).

Exaple of config in cris-authority-metadatagenerator.xml:

<bean class="org.dspace.content.authority.ItemSimpleAuthorityMetadataGenerator">
    <property name="authorityName" value="AuthorAuthority"/>
    <property name="keyId" value="person_identifier_orcid"/>
    <property name="useForDisplay" value="true"/>
    <property name="useAsData" value="true"/>
    <property name="schema" value="person"/>
    <property name="element" value="identifier"/>
    <property name="qualifier" value="orcid"/>
    <property name="singleResultOnAggregate" value="true"/>
</bean>

auto-fill.webm

The information of the related item are previewed via a new pop-up component enabled on hover, visible on both search results and item page:

In addition the PR introduce also multilanguage support for authority controlled vocabularies, to achieve this we need to have a vocabulary version for each language enabled by the property: webui.supported.locales

For instance if we have

webui.supported.locales = en, de

we can create a translated vocabulary (srsc_de in this example) and then configure the authority as follows (authority.cfg):

vocabulary.plugin.srsc.hierarchy.store = true
vocabulary.plugin.srsc.hierarchy.suggest = true
vocabulary.plugin.srsc.delimiter = "::"
vocabulary.plugin.authority.store = true
authority.controlled.dc.subject = true

This will enable to display the translated value in the UI, if the language matches the translated one:

EN:

DE:

This last feature will be consolidated later in the merger with the cust layout functionality from CRIS (at the moment this is not presente in the exact same way on CRIS as there we rely on the layout feature that is not yet in scope).
The implementation will remain anyway as it will be useful also as fallback for not configured layouts.

Instructions for Reviewers

Once the item relation is enstablished (submitted) the metadata will be linking to the related item, with a preview of metadata visible on link hover.

The new configuration for the pop-hover preview is available in default-app.config.ts, under the name:

metadataLinkViewPopoverData

It provides the opportunity to customize the preview metadata based on entity type.

In submission is possible also to configure specific icons for each source of authority, see config:

sourceIcons (under authority config)

In general for the newly added configuration you can refer to the config.example.yml file.

Once submitted, the authorithy controlled value should then result in a clickable link the search results (if the value is displayed) and in a clickable link in the item page (see images above).

Is possible to configure also auto-fill and generated metadata based on the authority (see descriptio or rest PR).

For the multilanguage support on vocabularies a translated vocabulary and submission form are needed, in addition to the properties based on the vocabulary name and metadata (see description).

List of changes in this PR:

Enhanced search results and item page with linkable related items (authority controlled)
Added new popover component for metadata preview on hover.
Implemented custom pipe for icon/info handling in onebox component.
Improved editing of authority via admin view, improved handling of search filters (filter by authorithy not value).
Implemented auto-fill functionality in submission.
Added support for multilanguage visualization of controlled vocabulary values in item page.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

… in item preview

…plate

github-actions · 2026-01-20T18:02:16Z

Hi @FrancescoMolinaro,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

artlowel

Thanks @FrancescoMolinaro

I haven't tested it yet, just did a code review for now. Most of it looks good, but I have a few inline comments

artlowel · 2026-01-29T09:35:32Z

config/config.example.yml

+followAuthorityMetadataValuesLimit: 5;
+
+# When the search results are retrieved, for each item type the metadata with a valid authority value are inspected.
+# Referenced items will be fetched with a find all by id strategy to avoid individual rest requests to efficiently display the search results.
+followAuthorityMetadata:
+  - type: Publication
+    metadata: dc.contributor.author


These are duplicated above

artlowel · 2026-01-29T09:37:00Z

src/app/core/shared/item.model.ts

+  /**
+   * A boolean representing if this Item is currently withdrawn or not
+   */


This comment is for something else

artlowel · 2026-01-29T09:49:12Z

config/config.example.yml

+    # Icons to be displayed next to an authority controlled value, to give indication of the source.
+    sourceIcons:
+      # Example of configuration for authority logo based on sources.
+      # The condigured icon will be displayed next to the authority value in submission and on item page or search results.


Typo: "condigured"

artlowel · 2026-01-29T10:08:05Z

src/app/core/data/external-source-data.service.ts

+  getExternalSourceEntryById(externalSourceId: string, entryId: string): Observable<RemoteData<ExternalSourceEntry>> {
+    const href$ = this.getEntryIDHref(externalSourceId, entryId).pipe(
+      isNotEmptyOperator(),
+      distinctUntilChanged(),
+    );
+
+    return this.findByHref(href$) as any;
+  }


This method doesn't seem to be used anywhere

artlowel · 2026-01-29T10:31:59Z

src/app/core/data/item-data.service.ts

+  public findById(id: string, useCachedVersionIfAvailable = true, reRequestOnStale = true, ...linksToFollow: FollowLinkConfig<Item>[]): Observable<RemoteData<Item>> {
+
+    if (uuidValidate(id)) {
+      const href$ = this.getIDHrefObs(encodeURIComponent(id), ...linksToFollow);
+      return this.findByHref(href$, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow);
+    } else {
+      return this.findByCustomUrl(id, useCachedVersionIfAvailable, reRequestOnStale, linksToFollow);
+    }
+  }
+


I think this check should be moved to the resolver. findById does one, well defined thing in all dataservices. The resolver should parse the route and determine whether to call findById or findByCustom URL, or even cleaner: move custom URLs to a different subroute, so you can have a separate resolver as well.

artlowel · 2026-01-29T10:43:49Z

src/app/core/shared/metadata.models.ts

+  /**
+   * Returns true if this Metadatum's authority key starts with 'virtual::'
+   */
+  get isVirtual(): boolean {
+    return hasValue(this.authority) && this.authority.startsWith(VIRTUAL_METADATA_PREFIX);
+  }
+
+  /**
+   * If this is a virtual Metadatum, it returns everything in the authority key after 'virtual::'.
+   * Returns undefined otherwise.
+   */
+  get virtualValue(): string {
+    if (this.isVirtual) {
+      return this.authority.substring(this.authority.indexOf(VIRTUAL_METADATA_PREFIX) + VIRTUAL_METADATA_PREFIX.length);
+    } else {
+      return undefined;
+    }
+  }


These methods were moved out of the models, to a service in #2875. In general we want to avoid having methods in models, as they cause issues with caching serialization etc

artlowel · 2026-01-29T11:06:38Z

src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.ts

+      tap((isHierarchical: boolean) => {
+        if (this.model.value) {
+          this.setCurrentValue(this.model.value, isHierarchical);
+        }
+      }),


It's not a good idea to do "work" in a tap(). Because that code will only be executed if something is subscribed to the pipe. It's better to have a dedicated subscription to do the value updates, that way you can be sure it happens every time the source observable updates.

artlowel · 2026-01-29T11:37:14Z

...app/shared/metadata-link-view/metadata-link-view-orcid/metadata-link-view-orcid.component.ts

+    this.orcidUrl$ = this.configurationService
+      .findByPropertyName('orcid.domain-url')
+      .pipe(
+        getFirstSucceededRemoteDataPayload(),


I suspect that, if orcid.domain-url isn't set on the server, there will never be a succeeded remote data, so this will never emit. Better deal with the failed case as well

FrancescoMolinaro · 2026-01-29T14:41:59Z

Hi @artlowel ,

thank you very much for the review and for the feedback. I have addressed all the points raised, with the exception of the custom URL aspect.

The custom URL functionality originates from #4814. Since this pull request builds upon that work, I believe it would be more appropriate to address any related issue directly within that original PR, if needed.

During the implementation, we chose to place the ID format control within the findById method because route resolvers and guards primarily rely on this method to retrieve item information from UUID/ID parameters in the URL.

Following the referenced PR, when the relevant metadata is present, the custom URL replaces the standard UUID/ID parameter in the page URL and effectively becomes a unique identifier for the item.

For this reason, we considered it preferable to keep the validation logic inside the findById method, as this approach minimizes the impact across the application and avoids the need to modify multiple code paths where the UUID/ID is extracted from the URL.

I would really appreaciate your thoughts on this reasoning and of course if it is not enough to justify the choice made I will make sure to adapt the code accordingly in the referenced pull request.

github-actions · 2026-02-05T20:47:46Z

Hi @FrancescoMolinaro,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

FrancescoMolinaro added 18 commits November 12, 2025 17:25

[DURACOM-413] port custom url functionality

bf14771

Merge remote-tracking branch 'gitHub/main' into task/main/DURACOM-413

66bd310

[DURACOM-413] additional tests

b42bf55

[DURACOM-413] update labels, fix sync script, adapt section handling

e88a40d

[DURACOM-413] update error handling/validation + resync translations

c93cb50

Merge remote-tracking branch 'gitHub/main' into task/main/DURACOM-413

75937c4

[DURACOM-413] fix lint

d1c1ecf

[DURACOM-426] init integration of authority framework

8bdfd01

Merge branch 'task/main/DURACOM-413' into task/main/DURACOM-426

a9dc8ec

[DURACOM-426] port metadata link components for authorithy

8c073ff

[DURACOM-426] fix some tests

d262480

[DURACOM-426] fix some unit tests

9c5e6bb

[DURACOM-426] fix tests and lint

a514b6e

[DURACOM-426] add authority link for md representation

a9ee4e5

Merge remote-tracking branch 'gitHub/main' into task/main/DURACOM-426

306029c

[DURACOM-426] clean up, add example, minor restyle, fix templates

36c77fe

[DURACOM-426] improve tests

e9f3df5

[DURACOM-426] refactor

5b6fa80

github-actions bot assigned FrancescoMolinaro Dec 19, 2025

FrancescoMolinaro changed the title ~~Task/main/duracom 426~~ Merger: porting of authority framework functionalities Dec 19, 2025

tdonohue added the DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. label Jan 8, 2026

tdonohue added this to DSpace 10.0 Release Jan 8, 2026

tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 8, 2026

[DURACOM-426] improve title configurability in popover, add link view…

b29dc1e

… in item preview

tdonohue added the new feature label Jan 15, 2026

tdonohue mentioned this pull request Jan 15, 2026

[DSpace-CRIS] Porting of authority framework functionalities (Backend) DSpace/DSpace#11718

Open

10 tasks

FrancescoMolinaro added 4 commits January 16, 2026 17:16

[DURACOM-426] add labels, fix facets labels,fix onebox other info tem…

3f35069

…plate

[DURACOM-426] filter data labels

1258bc2

[DURACOM-426] revert changes to lables, except for english

36e34a2

[DURACOM-426] add config example, remove unnecessary config

d2c0749

[DURACOM-426] clean config, add labels

1aef155

github-actions bot added the merge conflict label Jan 20, 2026

FrancescoMolinaro added 4 commits January 21, 2026 17:16

[DURACOM-426] add authority enrichment

995ff87

[DURACOM-426] fix tests

efc488a

[DURACOM-426] fix test and model update

252c249

[DURACOM-426] add vocabulary template in item field, adapt tests

e316b11

FrancescoMolinaro marked this pull request as ready for review January 22, 2026 16:50

tdonohue added the high priority label Jan 22, 2026

Merge remote-tracking branch 'gitHub/main' into task/main/DURACOM-426

317c1ee

github-actions bot removed the merge conflict label Jan 23, 2026

[DURACOM-426] fix lint

be381eb

artlowel self-requested a review January 29, 2026 08:27

artlowel requested changes Jan 29, 2026

View reviewed changes

github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release Jan 29, 2026

[DURACOM-426] refactor

a19ef43

tdonohue mentioned this pull request Feb 4, 2026

[DSpace-CRIS] Creation of a custom URL for Items (Frontend) #4814

Merged

12 tasks

tdonohue changed the title ~~Merger: porting of authority framework functionalities~~ [DSpace-CRIS] Porting of authority framework functionalities (Frontend) Feb 4, 2026

github-actions bot added the merge conflict label Feb 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DSpace-CRIS] Porting of authority framework functionalities (Frontend)#4956

[DSpace-CRIS] Porting of authority framework functionalities (Frontend)#4956
FrancescoMolinaro wants to merge 31 commits intoDSpace:mainfrom
4Science:task/main/DURACOM-426

FrancescoMolinaro commented Dec 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

artlowel left a comment

Uh oh!

artlowel Jan 29, 2026

Uh oh!

artlowel Jan 29, 2026

Uh oh!

artlowel Jan 29, 2026

Uh oh!

artlowel Jan 29, 2026

Uh oh!

artlowel Jan 29, 2026

Uh oh!

artlowel Jan 29, 2026

Uh oh!

artlowel Jan 29, 2026

Uh oh!

artlowel Jan 29, 2026

Uh oh!

FrancescoMolinaro commented Jan 29, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

FrancescoMolinaro commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

Description

Instructions for Reviewers

List of changes in this PR:

Checklist

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

artlowel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FrancescoMolinaro commented Jan 29, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

FrancescoMolinaro commented Dec 19, 2025 •

edited

Loading