Review/4 components p1 #4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,44 @@ | ||
| { | ||
| "name": "my-app", | ||
| "version": "0.1.0", | ||
| "private": true, | ||
| "dependencies": { | ||
| "@testing-library/jest-dom": "^5.16.4", | ||
| "@testing-library/react": "^13.2.0", | ||
| "@testing-library/user-event": "^13.5.0", | ||
| "@types/react": "^18.0.9", | ||
| "@types/react-dom": "^18.0.4", | ||
| "classnames": "^2.3.1", | ||
| "easy-bem": "^1.1.1", | ||
| "react": "^18.1.0", | ||
| "react-dom": "^18.1.0", | ||
| "react-scripts": "5.0.1", | ||
| "sass": "^1.52.1", | ||
| "typescript": "^4.6.4", | ||
| "web-vitals": "^2.1.4" | ||
| }, | ||
| "scripts": { | ||
| "start": "react-scripts start", | ||
| "build": "react-scripts build", | ||
| "test": "react-scripts test", | ||
| "eject": "react-scripts eject" | ||
| }, | ||
| "eslintConfig": { | ||
| "extends": [ | ||
| "react-app", | ||
| "react-app/jest" | ||
| ] | ||
| }, | ||
| "browserslist": { | ||
| "production": [ | ||
| ">0.2%", | ||
| "not dead", | ||
| "not op_mini all" | ||
| ], | ||
| "development": [ | ||
| "last 1 chrome version", | ||
| "last 1 firefox version", | ||
| "last 1 safari version" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| .genres-navigation { | ||
| width: 25%; | ||
|
|
||
| ul { | ||
| display: flex; | ||
| list-style-type: none; | ||
| } | ||
|
|
||
| li { | ||
| flex: auto; | ||
| } | ||
|
|
||
| &__tab:hover { | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| &__tab:visited { | ||
| color: gray; | ||
| } | ||
|
|
||
| &__genre { | ||
| color: white; | ||
|
|
||
| &--active { | ||
| border-bottom: 4px #f65261 solid; | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+1
to
+28
Collaborator
Author
There was a problem hiding this comment. Чем хорош SASS - например, что можно вкладывать селекторы один в другой, чтобы не утонуть в куче стилей элементов блока. SASS - это пре-процессор сителей, который умеет в переменные, импорты стилей из других модулей со стилями и много чего еще. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| .item-counter { | ||
| &__label { | ||
| font-size: 20px; | ||
| } | ||
|
|
||
| &__label_number { | ||
| font-weight: bolder; | ||
| } | ||
| } | ||
|
Comment on lines
+1
to
+9
Collaborator
Author
There was a problem hiding this comment. Еще пример вложения стилей |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,25 @@ | ||
| import React from 'react'; | ||
| import makeBEM from 'easy-bem'; | ||
|
|
||
| import './item-count-component.scss'; | ||
|
|
||
| const bem = makeBEM('item-counter'); | ||
|
|
||
| interface ItemsCountProps { | ||
| itemsCount?: number; | ||
| } | ||
|
|
||
| const ItemsCount: React.FC<ItemsCountProps> = props => { | ||
| return ( | ||
| <div className={bem()}> | ||
| <label className={bem('label_number')}>{props.itemsCount} </label> | ||
| <label className={bem('label')}>movies found</label> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| ItemsCount.defaultProps = { | ||
| itemsCount: 0, | ||
| }; | ||
|
Comment on lines
+21
to
+23
Collaborator
Author
There was a problem hiding this comment. Тут пример исопльзования значений попросов по-умолчанию |
||
|
|
||
| export { ItemsCount }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Таким образом
moviesDataтипизировать в текущих условиях не обязательно, просто хотел похвастаться системой типов в typescript.ReadonlyArrayзапретит менять ссылки в массиве (т.е. присвивать элементу другой объект), аReadonlyзапретит менять поля эленментаMovie