Skip to content

chore: add RafiM as a daskom1337 community member#36

Open
lionman9097 wants to merge 1 commit intoDaskom-Lab:mainfrom
lionman9097:main
Open

chore: add RafiM as a daskom1337 community member#36
lionman9097 wants to merge 1 commit intoDaskom-Lab:mainfrom
lionman9097:main

Conversation

@lionman9097
Copy link
Collaborator

I added and commited my ascii art and added my details to peoples.js

@lionman9097 lionman9097 marked this pull request as draft November 4, 2022 10:24
@lionman9097 lionman9097 marked this pull request as ready for review November 4, 2022 10:24
Copy link
Member

@fakhrip fakhrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Rafi, but please change the peoples.js based on my comment below first, thank you!

Comment on lines +149 to 159

{
Avatar: "RafiM.html",
Handle: "Bono Black Boy",
Realname: "Rafi Mahfuz Setyagraha",
Description: `
+------------------------------------------------+
| I am inside your walls |
+------------------------------------------------+`,
}];
}
Copy link
Member

@fakhrip fakhrip Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines is incorrect Rafi, you have to change it to something like this one

    ,
    {
        Avatar: "RafiM.html",
        Handle: "Bono Black Boy",
        Realname: "Rafi Mahfuz Setyagraha",
        Description: `
+------------------------------------------------+
|           I am inside your walls               |
+------------------------------------------------+`,
    }
  ];
}

You missed that , before the curly brace and also dont forget to put the ]; in the new line to keep things clean 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okeey bang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants