Clone values read from bbolt transactions to fix race

[pgimalac]

What does this PR do?

Clone slices obtained from bbolt and used outside the transaction.

Motivation

The documentation of bucket.Get says

The returned value is only valid for the life of the transaction.

We are returning and using those values outside the transaction, which leads to races while reading the value, and I suspect is the root cause of this panic while unmarshalling a payload.
https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1340109256#L237

Describe how you validated your changes

CI.

Additional Notes

[paulcacheux]

thanks for the fix ! but wow I don't like this return statement and how it depends on the order of evaluation :(
feel free to merge as-is, I will update this in a follow up PR !

[pgimalac]

If you know exactly what you want to change I can do it here (or you can push a commit), but if it's not trivial I'd rather let you do it in a separate PR yes 😄

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor beb0406
📊 Static Quality Gates Dashboard

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	docker_cluster_agent_amd64	+4.0 KiB (0.00% increase)	180.918 → 180.922 → 181.200
✅	iot_agent_deb_amd64	+4.0 KiB (0.01% increase)	42.774 → 42.778 → 43.290
✅	iot_agent_rpm_amd64	+4.0 KiB (0.01% increase)	42.775 → 42.779 → 43.290
✅	iot_agent_suse_amd64	+4.0 KiB (0.01% increase)	42.775 → 42.779 → 43.290

27 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	746.892 MiB
✅	agent_deb_amd64_fips	706.901 MiB
✅	agent_heroku_amd64	324.284 MiB
✅	agent_msi	659.176 MiB
✅	agent_rpm_amd64	746.876 MiB
✅	agent_rpm_amd64_fips	706.885 MiB
✅	agent_rpm_arm64	726.114 MiB
✅	agent_rpm_arm64_fips	688.553 MiB
✅	agent_suse_amd64	746.876 MiB
✅	agent_suse_amd64_fips	706.885 MiB
✅	agent_suse_arm64	726.114 MiB
✅	agent_suse_arm64_fips	688.553 MiB
✅	docker_agent_amd64	809.298 MiB
✅	docker_agent_arm64	813.085 MiB
✅	docker_agent_jmx_amd64	1000.210 MiB
✅	docker_agent_jmx_arm64	992.779 MiB
✅	docker_cluster_agent_arm64	196.744 MiB
✅	docker_cws_instrumentation_amd64	7.135 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	38.449 MiB
✅	docker_dogstatsd_arm64	36.749 MiB
✅	dogstatsd_deb_amd64	29.669 MiB
✅	dogstatsd_deb_arm64	27.833 MiB
✅	dogstatsd_rpm_amd64	29.669 MiB
✅	dogstatsd_suse_amd64	29.669 MiB
✅	iot_agent_deb_arm64	39.895 MiB
✅	iot_agent_deb_armhf	40.466 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+40.3 KiB (0.02% increase)	182.623 → 182.663 → 184.810
✅	agent_deb_amd64_fips	+18.79 KiB (0.01% increase)	174.072 → 174.090 → 177.560
✅	agent_heroku_amd64	-4.16 KiB (0.00% reduction)	87.088 → 87.084 → 88.450
✅	agent_msi	-48.0 KiB (0.03% reduction)	142.621 → 142.574 → 143.300
✅	agent_rpm_amd64	+12.17 KiB (0.01% increase)	185.675 → 185.687 → 188.160
✅	agent_rpm_amd64_fips	-18.17 KiB (0.01% reduction)	176.410 → 176.393 → 178.900
✅	agent_rpm_arm64	+70.72 KiB (0.04% increase)	168.225 → 168.294 → 169.930
✅	agent_rpm_arm64_fips	-4.31 KiB (0.00% reduction)	160.597 → 160.593 → 163.120
✅	agent_suse_amd64	+12.17 KiB (0.01% increase)	185.675 → 185.687 → 188.160
✅	agent_suse_amd64_fips	-18.17 KiB (0.01% reduction)	176.410 → 176.393 → 178.900
✅	agent_suse_arm64	+70.72 KiB (0.04% increase)	168.225 → 168.294 → 169.930
✅	agent_suse_arm64_fips	-4.31 KiB (0.00% reduction)	160.597 → 160.593 → 163.120
✅	docker_agent_amd64	neutral	274.674 MiB → 277.400
✅	docker_agent_arm64	neutral	262.231 MiB → 266.040
✅	docker_agent_jmx_amd64	neutral	343.315 MiB → 346.020
✅	docker_agent_jmx_arm64	-5.27 KiB (0.00% reduction)	326.865 → 326.860 → 330.660
✅	docker_cluster_agent_amd64	neutral	63.898 MiB → 64.510
✅	docker_cluster_agent_arm64	-5.7 KiB (0.01% reduction)	60.177 → 60.172 → 61.170
✅	docker_cws_instrumentation_amd64	neutral	2.994 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.726 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	14.876 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.216 MiB → 14.830
✅	dogstatsd_deb_amd64	+2.12 KiB (0.03% increase)	7.837 → 7.839 → 8.790
✅	dogstatsd_deb_arm64	neutral	6.725 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.850 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.850 MiB → 8.800
✅	iot_agent_deb_amd64	neutral	11.221 MiB → 12.040
✅	iot_agent_deb_arm64	neutral	9.595 MiB → 10.450
✅	iot_agent_deb_armhf	neutral	9.790 MiB → 10.620
✅	iot_agent_rpm_amd64	neutral	11.239 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.239 MiB → 12.060

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f5007fe1-15e5-4d19-95ff-d97396525f0c

Baseline: 00a36b0
Comparison: f8b22ee
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.97	[-2.12, +4.06]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+0.99	[+0.78, +1.20]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	+0.97	[-2.12, +4.06]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.52	[+0.42, +0.62]	1	Logs
➖	ddot_metrics	memory utilization	+0.52	[+0.29, +0.75]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.46	[+0.24, +0.67]	1	Logs
➖	ddot_logs	memory utilization	+0.40	[+0.34, +0.46]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.38	[+0.34, +0.41]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.25	[+0.20, +0.29]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.16	[+0.11, +0.21]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.15	[-0.01, +0.32]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.03	[-0.38, +0.44]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.02, +0.07]	1	Logs
➖	file_tree	memory utilization	+0.02	[-0.04, +0.07]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.37, +0.40]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.12, +0.12]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.10, +0.08]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.52, +0.49]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.02	[-0.15, +0.11]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.35	[-0.58, -0.12]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.52	[-2.01, +0.98]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	-0.52	[-0.67, -0.37]	1	Logs
➖	docker_containers_memory	memory utilization	-0.53	[-0.60, -0.46]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.74	[-0.83, -0.66]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[pgimalac]

/merge

[gh-worker-devflow-routing-ef8351]

View all feedbacks in Devflow UI.

2026-02-06 09:30:10 UTC ℹ️ Start processing command /merge

---

2026-02-06 09:30:15 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

---

2026-02-06 10:07:05 UTC ℹ️ MergeQueue: This merge request was merged