Skip to content

[ACTP] Add rc adapter in PAR#45985

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
merchristk-ACTP-par-rc-adapter
Feb 6, 2026
Merged

[ACTP] Add rc adapter in PAR#45985
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
merchristk-ACTP-par-rc-adapter

Conversation

@merchristK
Copy link
Contributor

@merchristK merchristK commented Feb 5, 2026

What does this PR do?

This PR adds an adapter for rcclient for all usages in the privateactionrunner.

Motivation

This is to allow easy integration with the cluster agent. The cluster agent doesn't use the fx component of RC which relies on IPC. Instead it uses a direct rcclient built from the available rcservice.

rcClient, err := rcclient.NewClient(rcService,
rcclient.WithAgent("cluster-agent", version.AgentVersion),
rcclient.WithCluster(clusterName, clusterID),
rcclient.WithProducts(products...),
rcclient.WithPollInterval(5*time.Second),
rcclient.WithDirectorRootOverride(config.GetString("site"), config.GetString("remote_configuration.director_root")),
)

To support both without too much hassle, we need an adapter.

Describe how you validated your changes

I ran the PAR in local with self enrolment and actions execution still works

Additional Notes

Copy link
Contributor Author

merchristK commented Feb 5, 2026

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 5, 2026
@merchristK merchristK added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/action-platform labels Feb 5, 2026
@agent-platform-auto-pr
Copy link
Contributor

Go Package Import Differences

Baseline: 197c8df
Comparison: 8bbed75

binaryosarchchange
privateactionrunnerlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/rcclient
privateactionrunnerlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/rcclient
privateactionrunnerwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/rcclient
privateactionrunnerdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/rcclient
privateactionrunnerdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/rcclient

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 197c8df
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +3.97 KiB (0.00% increase) 746.903 → 746.906 → 754.830
agent_msi +3.3 KiB (0.00% increase) 659.182 → 659.186 → 1072.620
agent_rpm_amd64 +3.97 KiB (0.00% increase) 746.886 → 746.890 → 754.800
agent_suse_amd64 +3.97 KiB (0.00% increase) 746.886 → 746.890 → 754.800
docker_agent_amd64 +3.97 KiB (0.00% increase) 809.309 → 809.313 → 817.140
docker_agent_jmx_amd64 +3.97 KiB (0.00% increase) 1000.220 → 1000.224 → 1008.020
25 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64_fips 706.908 MiB
agent_heroku_amd64 324.292 MiB
agent_rpm_amd64_fips 706.891 MiB
agent_rpm_arm64 726.122 MiB
agent_rpm_arm64_fips 688.561 MiB
agent_suse_amd64_fips 706.891 MiB
agent_suse_arm64 726.122 MiB
agent_suse_arm64_fips 688.561 MiB
docker_agent_arm64 813.092 MiB
docker_agent_jmx_arm64 992.786 MiB
docker_cluster_agent_amd64 180.927 MiB
docker_cluster_agent_arm64 196.745 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.449 MiB
docker_dogstatsd_arm64 36.749 MiB
dogstatsd_deb_amd64 29.669 MiB
dogstatsd_deb_arm64 27.833 MiB
dogstatsd_rpm_amd64 29.669 MiB
dogstatsd_suse_amd64 29.669 MiB
iot_agent_deb_amd64 42.782 MiB
iot_agent_deb_arm64 39.899 MiB
iot_agent_deb_armhf 40.470 MiB
iot_agent_rpm_amd64 42.783 MiB
iot_agent_suse_amd64 42.783 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +10.52 KiB (0.01% increase) 182.653 → 182.664 → 184.810
agent_deb_amd64_fips +15.18 KiB (0.01% increase) 174.047 → 174.062 → 177.560
agent_heroku_amd64 -2.96 KiB (0.00% reduction) 87.088 → 87.085 → 88.450
agent_msi +12.0 KiB (0.01% increase) 142.605 → 142.617 → 143.300
agent_rpm_amd64 +14.78 KiB (0.01% increase) 185.682 → 185.697 → 188.160
agent_rpm_amd64_fips -26.16 KiB (0.01% reduction) 176.462 → 176.436 → 178.900
agent_rpm_arm64 -10.01 KiB (0.01% reduction) 168.286 → 168.276 → 169.930
agent_rpm_arm64_fips +2.75 KiB (0.00% increase) 160.585 → 160.588 → 163.120
agent_suse_amd64 +14.78 KiB (0.01% increase) 185.682 → 185.697 → 188.160
agent_suse_amd64_fips -26.16 KiB (0.01% reduction) 176.462 → 176.436 → 178.900
agent_suse_arm64 -10.01 KiB (0.01% reduction) 168.286 → 168.276 → 169.930
agent_suse_arm64_fips +2.75 KiB (0.00% increase) 160.585 → 160.588 → 163.120
docker_agent_amd64 neutral 274.689 MiB → 277.400
docker_agent_arm64 neutral 262.236 MiB → 266.040
docker_agent_jmx_amd64 -2.74 KiB (0.00% reduction) 343.337 → 343.334 → 346.020
docker_agent_jmx_arm64 +4.77 KiB (0.00% increase) 326.866 → 326.871 → 330.660
docker_cluster_agent_amd64 neutral 63.890 MiB → 64.510
docker_cluster_agent_arm64 neutral 60.162 MiB → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.876 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.218 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.838 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.725 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.850 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.850 MiB → 8.800
iot_agent_deb_amd64 neutral 11.220 MiB → 12.040
iot_agent_deb_arm64 +2.17 KiB (0.02% increase) 9.593 → 9.595 → 10.450
iot_agent_deb_armhf neutral 9.790 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.236 MiB → 12.060
iot_agent_suse_amd64 neutral 11.236 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 00f2df77-fc9c-4aa0-a79f-7505d37ae815

Baseline: 197c8df
Comparison: 8bbed75
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.03 [-3.16, +3.09] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.84 [+1.74, +1.93] 1 Logs
quality_gate_logs % cpu utilization +1.10 [-0.43, +2.62] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.68 [+0.63, +0.74] 1 Logs
ddot_metrics memory utilization +0.65 [+0.43, +0.86] 1 Logs
otlp_ingest_logs memory utilization +0.64 [+0.53, +0.74] 1 Logs
quality_gate_idle_all_features memory utilization +0.43 [+0.39, +0.47] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.24 [+0.08, +0.40] 1 Logs
file_tree memory utilization +0.18 [+0.13, +0.23] 1 Logs
ddot_metrics_sum_delta memory utilization +0.16 [-0.02, +0.33] 1 Logs
quality_gate_idle memory utilization +0.12 [+0.07, +0.16] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.34, +0.47] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.46, +0.55] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.01 [-0.21, +0.24] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.11, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.10, +0.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.40, +0.39] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.13, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.06, +0.04] 1 Logs
docker_containers_cpu % cpu utilization -0.03 [-3.16, +3.09] 1 Logs
docker_containers_memory memory utilization -0.23 [-0.30, -0.16] 1 Logs
ddot_logs memory utilization -0.37 [-0.44, -0.30] 1 Logs
quality_gate_metrics_logs memory utilization -0.39 [-0.61, -0.17] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.47 [-0.62, -0.32] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@merchristK merchristK marked this pull request as ready for review February 6, 2026 08:49
@merchristK merchristK requested a review from a team as a code owner February 6, 2026 08:49
@merchristK
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 6, 2026

View all feedbacks in Devflow UI.

2026-02-06 09:10:13 UTC ℹ️ Start processing command /merge


2026-02-06 09:10:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-02-06 09:51:13 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 164e3eb into main Feb 6, 2026
356 of 359 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the merchristk-ACTP-par-rc-adapter branch February 6, 2026 09:51
@github-actions github-actions bot added this to the 7.77.0 milestone Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/action-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants