chore(ci): introduce code freeze flow using milestones#4276
chore(ci): introduce code freeze flow using milestones#4276
Conversation
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
b58b6ca to
6047729
Compare
BenchmarksBenchmark execution time: 2026-01-08 11:41:24 Comparing candidate commit 9560093 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 155 metrics, 9 unstable metrics. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 8d93017 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 956009383f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gh api \ | ||
| --method POST \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| "/repos/$REPO/statuses/$SHA" \ |
There was a problem hiding this comment.
Avoid failing forked PRs when posting status
This workflow runs on pull_request events but always posts a commit status via gh api to /statuses/$SHA. On forked PRs, GitHub Actions provides a read‑only GITHUB_TOKEN that cannot write commit statuses, so this POST returns 403 and the step fails. That means the workflow itself fails even when no code freeze is active, blocking merges for external contributors. Consider skipping the status update for forked PRs or using a safer event/permissions model.
Useful? React with 👍 / 👎.
What does this PR do?
This PR adds three workflows and an action (pr-updater) to enforce a code freeze. When a milestone is opened starting with "Incident" or "Code Freeze" it will make all the PR CI checks red so that it won't get merged. If a PR created and added to the active milestones it will be exempt from the freeze so that we can fix the issues that causes the code freeze.
Motivation
According the guidelines (https://datadoghq.atlassian.net/wiki/spaces/APMINT/pages/5734924301/Incident+and+code+freeze+rules), we want to freeze any further merges until we fix the issues with the CI or similar facilities.
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!