refactor(tracer/trace): add lock assertions to trace struct#4346
Draft
refactor(tracer/trace): add lock assertions to trace struct#4346
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-01-23 12:26:17 Comparing candidate commit 5257eb3 in PR branch Found 0 performance improvements and 13 performance regressions! Performance is the same for 142 metrics, 9 unstable metrics. scenario:BenchmarkExtractW3C-25
scenario:BenchmarkInjectW3C-25
scenario:BenchmarkOTelApiWithCustomTags/datadog_otel_api-25
scenario:BenchmarkOTelApiWithCustomTags/otel_api-25
scenario:BenchmarkPartialFlushing/Disabled-25
scenario:BenchmarkPartialFlushing/Enabled-25
scenario:BenchmarkSingleSpanRetention/no-rules-25
scenario:BenchmarkSingleSpanRetention/with-rules/match-all-25
scenario:BenchmarkSingleSpanRetention/with-rules/match-half-25
scenario:BenchmarkStartSpan-25
scenario:BenchmarkStartSpanConfig/scenario_WithStartSpanConfig-25
scenario:BenchmarkStartSpanConfig/scenario_none-25
scenario:BenchmarkTracerAddSpans-25
|
c4251df to
16a964f
Compare
933799c to
0af3842
Compare
…racer Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
0af3842 to
de7ca7b
Compare
de7ca7b to
b00e62a
Compare
…locking.RWMutex Migrates trace.mu from sync.RWMutex to locking.RWMutex to enable dynamic deadlock detection. Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
b00e62a to
80a3c36
Compare
Member
|
The impact on performance looks significant. Could it be flakiness? |
Member
Author
Quite possible. Until I know for sure. I'll mark it as draft. |
Base automatically changed from
kakkoyun/LANGPLAT-434/dynamic_lock_checks
to
main
January 20, 2026 06:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!