fix(appsec): align downstream body analysis env var with RFC#4398
Open
RomainMuller wants to merge 1 commit intomainfrom
Open
fix(appsec): align downstream body analysis env var with RFC#4398RomainMuller wants to merge 1 commit intomainfrom
RomainMuller wants to merge 1 commit intomainfrom
Conversation
The RFC for API Security downstream body analysis was updated to rename `DD_API_SECURITY_DOWNSTREAM_REQUEST_BODY_ANALYSIS_SAMPLE_RATE` to `DD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATE` (dropping the `REQUEST_` segment). The implementation was not updated to match, causing system-tests to fail when setting the env var under its new name. Rename the env var string in the constant definition, supported configurations registry (JSON and generated Go map), and test `t.Setenv` calls. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com> JJ-Change-Id: qktwru
github-actions
bot
added
the
apm:ecosystem
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-02-06 14:18:53 Comparing candidate commit 17e58c7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 73 metrics, 8 unstable metrics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The RFC for API Security downstream body analysis was updated to rename
DD_API_SECURITY_DOWNSTREAM_REQUEST_BODY_ANALYSIS_SAMPLE_RATEtoDD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATE(dropping theREQUEST_segment). The implementation was not updated to match, causingsystem-tests to fail when setting the env var under its new name.
EnvAPISecDownstreamRequestBodyAnalysisSampleRateconstantt.Setenvcalls inTestAppsecAPI10andTestAppsecHTTP30XCo-Authored-By: Claude Opus 4 noreply@anthropic.com